! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
upstream changes or provide more info on forked libical in orage
Status:
CLOSED: FIXED

Comments

Description Kevin Fenzi 2009-09-15 18:16:42 CEST
Greetings. I am the Fedora package maintainer for Orage. 
We have a policy of not bundling forked copies of packages inside other packages. 

Orage does this with libical. 

All I can find in the logs is: 

        * Orage is now dependent on local libical.
            - standard libical cannot be used due to several fixes
              done to Orage's private copy

Some questions: 

1. Would it be possible to push your changes upstream? libical has been dead in the past, but currently they seem somewhat alive. ;) 

2. If not, could you enumerate what your fixes are? Are they needed for Orage to function? or would just some features be changed by linking to the upstream libical? Would it be possible to add a '--with system-libical' or '--without internal-libical' or the like? 

3. The bundled version seems to be 0.24, but upstream is at 0.43. Perhaps your changes already are in? 

Thanks for your time...
Comment 1 Christoph Wickert editbugs 2009-09-15 20:07:19 CEST
(In reply to comment #0)
> Greetings. I am the Fedora package maintainer for Orage. 
> We have a policy of not bundling forked copies of packages inside other
> packages.

Same goes for Debian and others. And it's not only libical but also tzdata.
Comment 2 juha editbugs 2009-09-16 07:31:12 CEST
1. As far as I know libical is not maintained. Where do you see the new package?

2. I can list changes, yes. But the list is long. They are needed. Libical
did not work and I did not get any replies from the mainteiners, so I had to do 
real fixes.

3. I doubt it. Where do you see the new version?

I do not include tzdata. I use operating system tzdata, but convert that to 
libical format, which I do not think is available in its own package?
Comment 3 Christoph Wickert editbugs 2009-09-16 13:31:57 CEST
(In reply to comment #2)
> 1. As far as I know libical is not maintained. Where do you see the new
> package?

http://sourceforge.net/projects/freeassociation/

> I do not include tzdata. I use operating system tzdata, but convert that to 
> libical format, which I do not think is available in its own package?

I cannot find anything about the conversation in the build output, only this:

Making install in zoneinfo
make[2]: Entering directory `/builddir/build/BUILD/orage-4.6.1/libical/zoneinfo'
make[3]: Entering directory `/builddir/build/BUILD/orage-4.6.1/libical/zoneinfo'
make[3]: Nothing to be done for `install-exec-am'.
for dir in Africa America America/Argentina America/Indiana America/Kentucky Antarctica Arctic Asia Atlantic Australia Europe Indian Pacific; do \
	  /bin/sh ../../mkinstalldirs /builddir/build/BUILDROOT/orage-4.6.1-1.fc11.i386/usr/share/orage/zoneinfo/$dir; \
	  for tzfile in ./$dir/*.ics; do \
	    install -p -m 644 $tzfile /builddir/build/BUILDROOT/orage-4.6.1-1.fc11.i386/usr/share/orage/zoneinfo/$dir; \
	  done \
	done

So when does the conversation take place? And why are the ics files in the orage tarball are *exactly* the same ones that get installed then?

$ diff -dur ../rpmbuild/SOURCES/orage-4.6.1/libical/zoneinfo/ /usr/share/orage/zoneinfo/
Only in ../rpmbuild/SOURCES/orage-4.6.1/libical/zoneinfo/: Makefile.am
Only in ../rpmbuild/SOURCES/orage-4.6.1/libical/zoneinfo/: Makefile.in
Comment 4 juha editbugs 2009-09-16 14:06:14 CEST
those files belong to libical (not tzdata).

And indeed those are copy from the libical. But as they are badly wrong,
new Orage 4.7 will have conversion utility, which can be used to fix those.
(Naturally Orage 4.7 also has fixed files.)
Comment 5 juha editbugs 2009-09-17 06:21:28 CEST
I will check the new libical. Would be really great to be able to use it.
Comment 6 juha editbugs 2009-10-18 12:55:44 CEST
The new code looks good. They have adapted fixes from svn and from some other
places, so most of orage local modifications are indeed fixed.

Logged bug:
https://sourceforge.net/tracker/?func=detail&aid=2881277&group_id=16077&atid=116077

I will continue checking.
Comment 7 Kevin Fenzi 2009-10-18 17:07:54 CEST
Excellent news. Hopefully you can switch to upstream/external soon.
Comment 8 juha editbugs 2009-11-20 14:17:16 CET
Logged bug:
https://sourceforge.net/tracker/?func=detail&aid=2901161&group_id=16077&atid=116077

still checking more issues.
Comment 9 juha editbugs 2009-12-08 12:57:56 CET
logged bug/enhancement
https://sourceforge.net/tracker/?func=detail&aid=2910658&group_id=16077&atid=116077
As Orage now (=git version) has now all timezones from the os, we loose some with the libical way.
Comment 10 juha editbugs 2009-12-08 14:09:54 CET
commited this now to git.

Those two bugs have a workaround so that Orage should work also against the 
external libical. The third is enhancement and by adding the missing timezones
to zone.tab they can be used.

build with --disable-libical if you want to use the internal version. 
Orage now defaults to external libical if recent enough (>= 0.43) version is found.
Comment 11 Kevin Fenzi 2009-12-08 16:38:47 CET
Excellent! Thanks so much for the work on this...
Comment 12 juha editbugs 2011-01-18 14:12:39 CET
in 4.8.0

Bug #5764

Reported by:
Kevin Fenzi
Reported on: 2009-09-15
Last modified on: 2011-01-18

People

CC List:
1 user

Version

Attachments

Additional information