--- support.c 2009-09-11 00:07:30.539196716 +0300 +++ support.c.ebal 2009-09-11 00:08:22.075868949 +0300 @@ -52,10 +52,9 @@ if(path != NULL && *path != '\0'){ - DBG("exo_url_show(%s)", path); - exo_success = exo_url_show(path, NULL, NULL); + GError *error = NULL; - if(!exo_success){ + if ( !gtk_show_uri (NULL, path, 0, &error)){ gchar *cmd = g_strconcat("thunar \"", path, "\"", NULL); DBG("exec: %s", cmd); places_gui_exec(cmd); @@ -114,8 +113,9 @@ void places_load_file(const gchar *path) { + GError *error = NULL; if(path != NULL && *path != '\0') - exo_url_show(path, NULL, NULL); + gtk_show_uri (NULL , path, 0, &error); } /**
I assume your goal is to build with the library exo-1 instead of exo-0.3. Unfortunately, my version of Thunar depends on exo-0.3, and I don't have the time now to set up the latest code from git. I'll let this patch keep sitting for now. Sorry.
I can confirm the patchs allows compilation against exo-0.5.4 and works. But you need to change configure.in to check for exo-1 instead of exo-0.3 too for pkg-config.
Created attachment 3336 Fix and clean build for xfce4-places-plugin Hi, In attachement an enhanced patch to support exo >= 0.5 and xfce4-panel >= 4.7
Created attachment 3983 Use the preferred filemanager (In reply to comment #3) > Created attachment 3336 > Fix and clean build for xfce4-places-plugin > > Hi, > > In attachement an enhanced patch to support exo >= 0.5 and xfce4-panel >= 4.7 It seems Fedora 16 has picked up some variant of the patch in attachment 3336 . However, it fails to launch the preferred filemanager when a different one from Thunar is configured such as Nautilus. This patch, when applied over the patch in attachment 3336 causes the preferred filemanager to be correctly launched: --- a/panel-plugin/support.c +++ b/panel-plugin/support.c @@ -51,10 +51,8 @@ places_load_file_browser(const gchar *path) gboolean exo_success; if(path != NULL && *path != '\0'){ - - GError *error = NULL; - - if ( !gtk_show_uri (NULL, path, 0, &error)){ + if(!exo_execute_preferred_application("FileManager", path, + NULL, NULL, NULL)) { gchar *cmd = g_strconcat("thunar \"", path, "\"", NULL); DBG("exec: %s", cmd);
AFAICS this is fixed in 1.4.0. Close?
(In reply to comment #5) > AFAICS this is fixed in 1.4.0. Close? I concur after reviewing the code of -places-plugin-1.4.0/panel-plugin/support.c (and I'm closing the bug as such)