! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
system load plugin doesn't work on Solaris
Status:
RESOLVED: FIXED
Product:
Xfce4-systemload-plugin
Component:
General

Comments

Description Peter Tribble 2009-09-07 18:21:59 CEST
Created attachment 2530 
Patch for Solaris

As the title says, the systemload panel plugin doesn't work on Solaris.
Attached is a patch that fixes that.

The one additional piece of work that would need doing is to remove -lkvm from
the library list on Solaris, and add -lkstat.
Comment 1 Florian Rivoal editbugs 2010-11-05 16:26:57 CET
Thanks for this patch.

As I don't have access to a solaris system for testing it, I'd prefer if you could provide a complete patch including the library change you mentioned, so that you can actually test the full patch. If I made that missing part myself, I wouldn't really have a way of checking if I did it correctly.

Do you think you could do that?
Comment 2 Ken Mays 2011-10-09 01:46:24 CEST
Created attachment 3891 
Systemload patch for Solaris 11 portability

This patch provides fixes to port xfce4-systemload-plugin 1.0.0 to the Oracle Solaris 11 and OpenSolaris-based distros.
Comment 3 Ken Mays 2011-10-09 01:53:03 CEST
(In reply to comment #1)
> Thanks for this patch.
> 
> As I don't have access to a solaris system for testing it, I'd prefer if you
> could provide a complete patch including the library change you mentioned, so
> that you can actually test the full patch. If I made that missing part myself,
> I wouldn't really have a way of checking if I did it correctly.
> 
> Do you think you could do that?

Ref: xfce4-systemload-plugin 1.0.0

Florian - You can resolve this ticket as we've modified and tested the patch for  xfce4-systemload-plugin 1.0.0 and it can be used with the  '-lkstat' in CFLAGS on Solaris/OpenSolaris-based platforms (__sun__). The compile is clean and works.
Comment 4 Landry Breuil editbugs 2012-04-18 15:39:41 CEST
Applied in http://git.xfce.org/panel-plugins/xfce4-systemload-plugin/commit/?id=386c890da02e05ad4a777ee8b61b689cf3200a00

A configure.ac.in patch to add the correct libs for Solaris would be welcome (as for battery/wavelan/diskperf/mount/any other plugin you plan to add support for solaris..)

Bug #5743

Reported by:
Peter Tribble
Reported on: 2009-09-07
Last modified on: 2012-04-18

People

Assignee:
Landry Breuil
CC List:
3 users

Version

Version:
0.4.2 or older

Attachments

Patch for Solaris (4.53 KB, application/octet-stream)
2009-09-07 18:21 CEST , Peter Tribble
no flags
Systemload patch for Solaris 11 portability (4.15 KB, patch)
2011-10-09 01:46 CEST , Ken Mays
maybird1776 : review+

Additional information