! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xffm cannot browse smb shares
Status:
CLOSED: FIXED
Severity:
critical

Comments

Description juex 2003-12-27 19:43:44 CET
xffm 4.0.2, samba 3.0.1

while trying to access the smb network xffm hangs and CPU
load raises to 100%. In the status window I can see:

Looking for master browsers ...
XFSAMBA> nmblookup -M -- -

The same setup with 4.0.1 worked fine, if I execute the
nmblookup command on the commandline, I get the correct
master browser:

$> nmblookup -M -- -
querying __MSBROWSE__ on 192.168.0.255
192.168.0.90 __MSBROWSE__<01>
Comment 1 edscott editbugs 2003-12-28 16:48:43 CET
It could be that the version of samba you are using has a signal handler
attached to sigcont. Please apply this patch in reverse (or copy libs/tubo.c)
from the 4.0.1 tree to the 4.0.2 tree and confirm that xfsamba4 works (or does
not):

diff -u -N -r /usr/home/common/CVS/lunar/xfce_4_0_1/xfce4/xffm/libs/tubo.c
/usr/home/common/CVS/lunar/xfce_4_0_2/xfce4/xffm/libs/tubo.c
--- /usr/home/common/CVS/lunar/xfce_4_0_1/xfce4/xffm/libs/tubo.c Sat Dec 27
09:10:48 2003
+++ /usr/home/common/CVS/lunar/xfce_4_0_2/xfce4/xffm/libs/tubo.c Sat Dec 20
16:52:30 2003
@@ -300,6 +300,7 @@
fork_struct *forkO;
int status;
forkO = (fork_struct *) ((long)fork_object);
+ if (kill(forkO->childPID,SIGCONT) == 0) return TRUE;
waitpid(forkO->childPID, &status, WNOHANG);
if(WIFEXITED(status))
{
@@ -537,8 +538,10 @@
forkO->operate_stdout = NULL;
forkO->operate_stderr = NULL;

- if(forkO->childPID)
+ if(forkO->childPID){
kill(forkO->childPID, SIGTERM);
+ kill(forkO->childPID, SIGKILL);
+ }
if(cleanup)
(*cleanup) ();
Comment 2 juex 2003-12-29 13:23:36 CET
Yep, confirmed. xfsamba4 works if i use tubo.c from the 4.0.1 tree.
Comment 3 edscott editbugs 2003-12-29 16:10:21 CET
Perfect. As soon as I do some testing of samba-3.0.1 on FreeBSD I will update
CVS and close the bug. Thanks.
Comment 4 edscott editbugs 2003-12-29 20:09:08 CET
Please test with the file uploaded to bugviewer replacing libs/tubo.c to close
bug.
Comment 5 juex 2003-12-30 09:39:48 CET
Yes, works. Thanks.
Comment 6 edscott editbugs 2003-12-30 14:14:11 CET
Thank you for your cooperation.

Bug #57

Reported by:
juex
Reported on: 2003-12-27
Last modified on: 2009-07-14

People

Assignee:
edscott
CC List:
0 users

Version

Version:
unspecified

Attachments

0000057-tubo.c (12.65 KB, application/octet-stream)
2003-12-29 20:07 CET , juex
no flags

Additional information