I had like to propose this feature request, a keyboard shortcut (Ctrl-+/-) that will resize the font size. I have used it in gnome-terminal and konsole so far, and I find that very nice.
Been playing with this a bit, but konsole never changes the window size (but adjusting the grid of the vte widget) while gnome terminal resizes the window. I think I prefer the konsole way, but that involves a bit more calculation to avoid weird resizes.
That would be a very nice improvement indeed. A very common usecase is switching font size when trying to show something on ones tiny laptop's screen to someone not really used to such a tiny screen. Having to go through preferences, font size, etc. isn't really nice. ;) As for the final implementation, I guess one could live with a gnome-terminal-like behaviour until a konsole-like one is available; that would be a major improvement over having no such feature at all. (And there are already some bugs about resizing issues, like #4331 or #4728 anyway.)
Created attachment 2873 Some code for temporary change of font size
I have tried to write some code, but I am not sure if I am thinking in right way. Some known issues: * I wasn't able to set key binding for <control>plus; after pressing Ctrl+"+" Terminal terminates with message GLib-GObject-WARNING **: IA__g_object_notify: object class `TerminalWidget' has no property named `font-scale' * I am calling g_object_get(G_OBJECT (screen->preferences), "font-name", &font_name, NULL); for determining actual font size -- but will it always return correct string (e.g. "Some Font 12")? * With multiple tabs it sometimes works correctly, sometimes the whole window changes its size.
Hi, I continued the work by Rostislav Lisovy. I tried to improve the provided patch a little bit: * It uses the pango functions to specify the size of the font. * Use "<Ctrl>plus" and "<Ctrl>minus" as the default shourtcuts for the zoom. * Include the "Normal size" functionality in order to return to the size of the preferences. * Make the hot updating of the font preference and zoom cohexist. * Included consistent gtk icons. Still remaining issues: * With multiple tabs it sometimes works correctly, sometimes the whole window changes its size. (Maybe this home something in common with the resizing issues or maybe not). I include the patch. Kind regards, Asier
Created attachment 2912 Support for this feature
Regarding the resizing issue, I had wish it was simply treated as a separate bug, cause it seems to be currently attached to the font changing e.g. go into the preferences and switch the font, it will also resize the window. I had say that the behaviour from Konsole is the best fit (the window size never changes). And that's just my 2 cents.
The window resizing is bad, so this patch is still not suitable for master.
*** Bug 6823 has been marked as a duplicate of this bug. ***
Asier patch is awesome. I was trying to investigate the case of window resizing, but i seems that problem is in several places. 1st is in terminal-window.c: - g_signal_connect_swapped (G_OBJECT (window->preferences), "notify::font-name", - G_CALLBACK (terminal_window_set_size), window); Removed this callback fixing resizing issue if only 1 tab is openned. I was unable to find 2nd issue. Probably somebody else will investigate deeper.
*** Bug 7975 has been marked as a duplicate of this bug. ***
*** Bug 7976 has been marked as a duplicate of this bug. ***
It would be really nice if this option only affected the font size in the one window under consideration rather than in every xfce4-terminal window, as changing the options does. Also, for my 2 cents, I actually like the automatic changing of the window size, a-la GNOME, as this allows something like emacs or the like to continue to show the identical content, only larger. Thanks for the work on this!
(In reply to comment #13) > It would be really nice if this option only affected the font size in the > one window under consideration rather than in every xfce4-terminal window, > as changing the options does. > > Also, for my 2 cents, I actually like the automatic changing of the window > size, a-la GNOME, as this allows something like emacs or the like to > continue to show the identical content, only larger. > > Thanks for the work on this! I second this opinion 100% +Window resizes relative to font size +Manual resizing is per tab/window and independent of global prefs. Looking forward to trying A. Liano's patch to see if it fits the bill.
Created attachment 4895 support font zooming Hi, a Debian user provided this other patch to enable this feature (and it adds a --font and --zoom command line arguments).
last patch works just brilliant. I think will be nice to merge. :)
Thanks, I will review the patch.
Created attachment 6749 patch against master To make it easier attaching a patch against the latest master. Thank you for you work Igor! Really nice to see app moving forward.
Thanks! Merged in http://git.xfce.org/apps/xfce4-terminal/commit/?id=77194638860b9ddfe14e11bcad3fa9b66f840d8f
I just wanted to say Thank You for having implemented this feature. I really look forward to using it.
Joel, thanks for keeping interest in xfce4-terminal!
Thank you for having implemented that, I wanted it for years, just found the bug and installed (still marked unstable in Gentoo) x11-terms/xfce4-terminal-0.6.92 So far it works great! Is there a way to extend that functionality and attach the zoom-{in,out} functionality to Ctrl+{button4,button5} so it works similar to a browser? I don't often use the mouse on a terminal, but showing a terminal on a projector screen for some demo often requires it, so it will be helpful. Not sure about the policies on this Bugzilla, please let me know if I rather need to submit a new issue.
(In reply to Kalin KOZHUHAROV from comment #22) > Thank you for having implemented that, I wanted it for years, just found the > bug and installed (still marked unstable in Gentoo) > x11-terms/xfce4-terminal-0.6.92 > > So far it works great! > > Is there a way to extend that functionality and attach the zoom-{in,out} > functionality to Ctrl+{button4,button5} so it works similar to a browser? > I don't often use the mouse on a terminal, but showing a terminal on a > projector screen for some demo often requires it, so it will be helpful. > > Not sure about the policies on this Bugzilla, please let me know if I rather > need to submit a new issue. Thanks for nice words! Yes, please submit a new one for your request.