! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
View menu in the git branch does not contain enough items to be a functional ...
Status:
RESOLVED: FIXED
Product:
Mousepad
Component:
General

Comments

Description Nick Schermer editbugs 2009-07-23 11:38:26 CEST
Created attachment 2463 
Move document menu in view menu (path by Juergen).

Title says it all. The view menu contains only the statusbar and font actions.

Juergen Kazmirzak contacted me about this, to move all the items in the document menu to the view menu, but I don't feel very comfortable with this since a number of the options in the document menu don't fit in the "view category" (eol, write-bom, insert-spaces). The patch he send me is attached.

Another option would be moving the "show statusbar" option below the line-numbers option and make this setting per-document. This should also be possible with the font option, but I'd like to keep this option application wide. We could mention this in the tooltip and font-dialog title, i guess that will be enough.
Comment 1 Jürgen Kazmirzak 2009-07-23 16:07:55 CEST
Ok, following your reasoning we should then make a clear distinction.

1) A view menu shall be there for things that don't change the document:
* Auto Indent  (tab-based)
* Tab Size     (tab-based)
* Word Wrap    (tab-based)
* Statusbar    (tab-based)
* Line numbers (tab-based)
* ------------
* Font         (applicationwide)


2) With that only two advanced options are left, which do change the text itself:
* Line Ending       (tab-based)
* Write Unicode BOM (tab-based)

It would now make sense to put these two rather advanced and seldomly used functions to the menu "Text". Converting tabs to spaces is a similar functionality to converting line endings from Linux to Windows, so menu would be very consistent. 

I strongly recommend this approach because the view menu traditionally contains the easy settings like line numbers and statusbars. Nearly every application handles it like that. The "Text" menu would then be the special-advanced-mousepad-menu whose function is obviously to *manipulate* the text in certain ways.

If I can find general agreement from the main devs, patch will be provided.
Comment 2 Jürgen Kazmirzak 2009-07-25 20:26:23 CEST
P.S. if the name "view" menu like introduced above still causes stomach pains it could possibly be named "Options" as it was named in earlier versions. That would be pretty straightforward as well.
Comment 3 Nick Schermer editbugs 2009-08-06 07:51:28 CEST
Yeah, removing the document menu and moving the items to either the view or text menu seems ok to me.
Comment 4 Jürgen Kazmirzak 2009-08-07 13:18:13 CEST
Created attachment 2494 
git diff patch rearranging the menu structure and making statusbar tab-based

solves the bug
Comment 5 Andre Miranda editbugs 2013-11-06 04:35:24 CET
I agree with Jürgen's argument, Text and Document menus seems redundant, so a merge and moving some functions to View is a nice idea. Even tough Mousepad has been rewritten and the patch probably can't be applied anymore, this reasoning is still worth for consideration.
Comment 6 Matthew Brush editbugs 2014-07-12 05:40:46 CEST
I have re-arranged the main menu a bit and added some more stuff to the View menu in master branch. It's kind of based on Geany and Gedit's layouts a little. Does it look OK now?
Comment 7 Andre Miranda editbugs 2014-07-12 18:04:15 CEST
Seems better now.
I'd just reorder the Document menu to:
[] Auto Indent
[] Word Wrap
[] Write BOM Unicode
------------
Filetype >
Line Ending >
Tab Size >
Comment 8 Theo Linkspfeifer editbugs 2019-06-17 23:53:34 CEST
Created attachment 8646 
patch

My proposal:

[] Word Wrap
[] Auto Indent
Tab Size >
------------
Filetype >
Line Ending >
------------
[] Write BOM Unicode
Comment 9 Andre Miranda editbugs 2019-06-17 23:55:55 CEST
(In reply to Theo Linkspfeifer from comment #8)
> Created attachment 8646 
> patch
> 
> My proposal:
> 
> [] Word Wrap
> [] Auto Indent
> Tab Size >
> ------------
> Filetype >
> Line Ending >
> ------------
> [] Write BOM Unicode

What's the rationale? Mine was to group checkboxes and submenus.
Comment 10 Theo Linkspfeifer editbugs 2019-06-18 00:06:43 CEST
It makes more sense to group Auto Indent and Tab Size. Write BOM Unicode does not appear to be that important, so it should stay at the bottom.
Comment 11 Andre Miranda editbugs 2019-06-18 00:12:59 CEST
Fine, merged into master:
https://git.xfce.org/apps/mousepad/commit/?id=74ea3a0

Bug #5604

Reported by:
Nick Schermer
Reported on: 2009-07-23
Last modified on: 2019-06-18

People

Assignee:
Matthew Brush
CC List:
5 users

Version

Target Milestone:
Mousepad 0.4.x

Attachments

Additional information