Hello, Another bug again because I feel some cleansing in the right click menu of the tray icon may be helpful. At the time i'm writing i'm still not sure of the meaning of the third entry : 'Disable with a V icon' or 'Enable with a X icon'. It's actually confusing to have those icons meaning the exact contrary of the text, not to mention that i dont know what it enables or disables. This is why I propose you replace this line by a checkbox menu entry (Thunar has one in it's 'view' menu, but I'm pretty sure you know what I mean), and change the title to something more meaningful of the feature it enables or disables. Also, I think the 'Information' entry should either be named 'Battery information' or even moved to the preferences menu as it is now clear what it informs about, and as it is something that is *almost* never used. The same is true for 'Help' and 'About', they are not the most used features so it may be better to move them in the preferences aswell in order to keep the tray icon efficient. Finally, do you know if users actually use the "Quit" button ? I personally let my daemon live continuously, and if i dont need it anymore my first reflex is to killall *-power-manager. Is it really needed in the tray ? PS : if you do all the things i wrote above, there is plenty of space in the tray for other features (no idea which, though) :)
(In reply to comment #0) > Hello, > > Another bug again because I feel some cleansing in the right click menu of the > tray icon may be helpful. At the time i'm writing i'm still not sure of the > meaning of the third entry : 'Disable with a V icon' or 'Enable with a X icon'. > It's actually confusing to have those icons meaning the exact contrary of the > text, not to mention that i dont know what it enables or disables. > > This is why I propose you replace this line by a checkbox menu entry (Thunar > has one in it's 'view' menu, but I'm pretty sure you know what I mean), and > change the title to something more meaningful of the feature it enables or > disables. > You mean the inhibit option? > Also, I think the 'Information' entry should either be named 'Battery > information' or even moved to the preferences menu as it is now clear what it > informs about, and as it is something that is *almost* never used. The same is > true for 'Help' and 'About', they are not the most used features so it may be > better to move them in the preferences aswell in order to keep the tray icon > efficient. Preferences dialog is another program and it doesn't have any information about any battery, probably changing it to device information or battery information makes sense, but there is no problem with this. Same for Help and About, almost lot of panel plugins+tray icons shows these informations, also the preferences dialog has help button already, i don't see a point here, but feel free to patch if you like, the code is in xfpm-tray-icon.c and used by all the tray icons (battery, adapter, ...). > > Finally, do you know if users actually use the "Quit" button ? I personally let > my daemon live continuously, and if i dont need it anymore my first reflex is > to killall *-power-manager. Is it really needed in the tray ? Correct, but i was asked on the goodies mailing list by many people before to add a quit option in the context menu, so i did that, personally i don't care having or not having it, but also i would say it is okay to keep it for the moment.
The most important part of this report (the checkbox menu item) has been addressed, and I'm ok with the other items as they are (even if I'd prefer if you rename "Information" to "Battery information" :-p). I think you can close the bug. Thanks for your answer and your fix for the "Monitor power control" menu item!
(In reply to comment #2) > The most important part of this report (the checkbox menu item) has been > addressed, and I'm ok with the other items as they are (even if I'd prefer if > you rename "Information" to "Battery information" :-p). > > I think you can close the bug. Thanks for your answer and your fix for the > "Monitor power control" menu item! Soon i will put the devkit-power branch into master, then i can ask translators to translate the new message, so i can add battery information, but the only one thing that prevents me, is that Battery information is long and makes the menu ugly.