! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Destroying summary window opens up help window.
Status:
RESOLVED: FIXED
Product:
Xfce4-weather-plugin
Component:
General

Comments

Description Erik Xian 2009-06-15 23:52:51 CEST
Created attachment 2403 
A proposed patch.

When the summary window is closed through the window manager (such as through a key combination), it closes the window and then opens up the help window.

I believe piece of code in panel-plugin/weather-summary.c is responsible:

	if (response == GTK_RESPONSE_ACCEPT)
		gtk_widget_destroy(window);
	else
 		g_spawn_command_line_async ("exo-open --launch WebBrowser " PLUGIN_WEBSITE, NULL);

To fix this, I altered that to:

	if (response == GTK_RESPONSE_HELP)
		g_spawn_command_line_async ("exo-open --launch WebBrowser " PLUGIN_WEBSITE, NULL);
	else
 		gtk_widget_destroy(window);

which seems to fix this problem.
Comment 1 Colin Leroy 2009-06-16 06:43:46 CEST
Fixed in SVN (with an adapted patch), thanks for the report and patch.

Bug #5471

Reported by:
Erik Xian
Reported on: 2009-06-15
Last modified on: 2010-11-09

People

Assignee:
Colin Leroy
CC List:
2 users

Version

Version:
0.7.3 or older

Attachments

A proposed patch. (534 bytes, patch)
2009-06-15 23:52 CEST , Erik Xian
no flags

Additional information