! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-notes-plugin r7489: compilation errors
Status:
RESOLVED: FIXED
Product:
Xfce4-notes-plugin
Component:
General

Comments

Description Jos van Wolput 2009-06-07 01:34:43 CEST
make xfce4-notes-plugin r7489 shows the following errors:
---
/usr/bin/valac --vapidir=. --pkg=config --pkg=color --pkg=libxfconf-0 --pkg=libxfce4panel -1.0 main.vala application.vala window.vala note.vala hypertextview.vala -C
error: libxfconf-0 not found in specified Vala API directories
error: libxfce4panel-1.0 not found in specified Vala API directories
Compilation failed: 2 error(s), 0 warning(s)
make[2]: *** [vala.stamp] Error 1
make[2]: Leaving directory `/home/jos/src/xfce4/goodies/xfce4-notes-plugin/panel-plugin'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/jos/src/xfce4/goodies/xfce4-notes-plugin'
make: *** [all] Error 2
---
Comment 1 Mike Massonnet editbugs 2009-06-07 03:50:13 CEST
Sure. You need the VAPI files from xfce4-vala, and actually that reminds me that I'll have to install a separate pkg-config file with it.
Comment 2 Mike Massonnet editbugs 2009-06-07 04:33:24 CEST
Now when running in maintainer-mode (./configure --enable-maintainer-mode), which is the default when compiling from SVN, it will check for xfce4-vala 0.1.
Comment 3 Jos van Wolput 2009-06-07 05:08:55 CEST
(In reply to comment #2)

I installed the required xfce4-vala-0.1 but now get a new error:
---
/usr/bin/valac --vapidir=. --pkg=config --pkg=color --pkg=libxfconf-0 --pkg=libxfce4panel-1.0 main.vala application.vala window.vala note.vala hypertextview.vala -C
main.vala:88.3-88.69: error: Too few arguments, method `Xfce.textdomain' does not take 2 arguments
                Xfce.textdomain (Config.GETTEXT_PACKAGE, Config.PACKAGE_LOCALE_DIR);
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Compilation failed: 1 error(s), 0 warning(s)
make[2]: *** [vala.stamp] Error 1
make[2]: Leaving directory `/home/jos/src/xfce4/goodies/xfce4-notes-plugin/panel-plugin'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/jos/src/xfce4/goodies/xfce4-notes-plugin'
make: *** [all] Error 2
---
Comment 4 Mike Massonnet editbugs 2009-06-07 05:24:21 CEST
Damn, I actually forgot to commit the updated vapi files :/ I just updated xfce4-vala, if you cloned from git then please pull.

If you took a tarball, you can edit $prefix/share/vala/vapi/libxfce4util-1.0.vapi and change the line:

  public static void textdomain (string package, string localedir, string? encoding);

against

  public static void textdomain (string package, string localedir, string? encoding = null);

Thank you for your report!
Comment 5 Jos van Wolput 2009-06-07 06:25:04 CEST
(In reply to comment #4)
I get the xfce files from svn. The latest version of the notes plugin I have is revision 7491.
After applying the change 'encoding = null' in usr/share/vala/vapi/libxfce4util-1.0.vapi I now get another error:
---
gcc: @THUNAR_VFS_CFLAGS@: No such file or directory
main.c: In function ‘notes_plugin_construct’:
main.c:199: warning: assignment from incompatible pointer type
make[3]: *** [xfce4_notes_plugin-main.o] Error 1
make[3]: Leaving directory `/home/jos/src/xfce4/goodies/xfce4-notes-plugin/panel-plugin'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/jos/src/xfce4/goodies/xfce4-notes-plugin/panel-plugin'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/jos/src/xfce4/goodies/xfce4-notes-plugin'
make: *** [all] Error 2
---
I recompiled Thunar but that didn't remove the error!
Comment 6 Mike Massonnet editbugs 2009-06-07 09:32:17 CEST
Should be fixed too by now. Now it should compile at last.
Comment 7 Jos van Wolput 2009-06-07 10:20:57 CEST
(In reply to comment #6)
> Should be fixed too by now. Now it should compile at last.

Fixed in revision 7493.
Thanks!

Jos v.W.

Bug #5431

Reported by:
Jos van Wolput
Reported on: 2009-06-07
Last modified on: 2009-07-15

People

Assignee:
Mike Massonnet
CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information