! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Add .xz .tar.xz .txz support to xarchiver
Status:
RESOLVED: MOVED
Severity:
enhancement
Product:
Xarchiver
Component:
general

Comments

Description Robby Workman editbugs 2009-06-05 19:57:56 CEST
Created attachment 2385 
Add xz support

Attached patch is a start, but it's not complete, and I'm not finding how to complete it :/
The compiled result will open .txz files and add to them, but tar.xz is still not an option for creating new archives ; I've missed something somewhere...
Comment 1 Giuseppe Torelli 2009-06-06 20:10:34 CEST
(In reply to comment #0)
>I've missed something somewhere...

Thank you so much for your kind interest in Xarchiver. I think you missed the code that looks for the xz executable. Look at src/main.c:305

void xa_set_available_archivers()

Let me know about it. Thanks.
Comment 2 Robby Workman editbugs 2009-06-07 02:53:03 CEST
Created attachment 2388 
Try #2

Yep, that was it.  Thanks for the hint.  
I think there's still a problem somewhere, as I'm getting a memory fault trying to create *any* archive now, but at least this does allow the option of creating .xz and .tar.xz archives.  I'll poke around some more and find out whether I caused the crash problem :-)
Comment 3 Robby Workman editbugs 2009-06-08 05:18:30 CEST
I can't reproduce the crash now; creating new archives seems fine.
I'm a C noob, to be honest, but this seemed like "low hanging fruit," so I decided to give it a shot.  Please review to make sure I didn't do anything obviously wrong, but I think it's okay to commit now.  Caveat lector  :-)
Comment 4 Giuseppe Torelli 2009-06-08 07:18:16 CEST
(In reply to comment #3)
> I can't reproduce the crash now; creating new archives seems fine.
> I'm a C noob, to be honest, but this seemed like "low hanging fruit," so I
> decided to give it a shot.  Please review to make sure I didn't do anything
> obviously wrong, but I think it's okay to commit now.  Caveat lector  :-)

Thank you so much for improving Xarchiver. I will review the patch in the next days and if everything works I will commit it. Do you want me to include your name in the About window of Xarchiver? If so please tell me exactly your name and surname or nickname and if I have to include your email.

Giuseppe
Comment 5 Robby Workman editbugs 2009-06-08 18:21:08 CEST
No need for About window decorations :-)
In the ChangeLog, if you would list the patch as coming from "Robby Workman <rworkman@slackware.com>" though, that would be good.  Thanks! :-)
Comment 6 Thomas Spura 2010-06-06 20:27:22 CEST
Hi,

I'm just getting started with xarchiver and unfortunately can't resolve this atm.

Here is a segfault, when trying to extract a tar.xz archive with the commandline option '-x'...

Does that work for you with your patch?
Comment 7 Robby Workman editbugs 2010-06-06 21:07:28 CEST
Created attachment 3008 
Current version of the patch

Hi Thomas,
I don't actually use xarchiver these days, but I'm attaching the last version of the patch that I used (and it didn't get any negative feedback that I recall).  
Xarchiver's maintainer moved everything back over to sourceforge and started a rewrite, so I moved on...  :-)
Comment 8 Robby Workman editbugs 2014-11-11 06:02:35 CET
Xarchiver is no longer hosted in the Xfce repositories, so this bug is essentially invalid. The important thing is that it be closed, I think.

Bug #5427

Reported by:
Robby Workman
Reported on: 2009-06-05
Last modified on: 2014-11-11

People

Assignee:
Giuseppe Torelli
CC List:
1 user

Version

Version:
unspecified

Attachments

Add xz support (13.29 KB, patch)
2009-06-05 19:57 CEST , Robby Workman
no flags
Try #2 (13.63 KB, patch)
2009-06-07 02:53 CEST , Robby Workman
no flags
Current version of the patch (14.19 KB, patch)
2010-06-06 21:07 CEST , Robby Workman
no flags

Additional information