Created attachment 2332 libxfcegui4: fix two SEGVs When there is not xfce4-session-manager process an attempt to start xfce4-settings-helper by hand creates the warning message, ----- (xfce4-settings-helper:86452): xfce4-settings-helper-WARNING **: Failed to connect to session manager ----- and then settings-helper dumps core due to the segmentation violation. There are at least two places in libxfcegui4 that will provoke SEGV: 1. call to SmcCloseConnection when no connection was established; 2. an attempt to g_strfreev() of clone_command that contains pointers to a static strings. The attached patch fixes these issues and it allows me to start settings-helper without active session manager.
Yeah, patch looks good. Someone should check this in if I don't get to it sooner.
Any progress with this issue? The patch still applicable and still fixes my problems.
Your patch probably doesn't apply anymore due to a patch from an older bug that just went in a week ago. The strdupv things should be fixed, not sure about the other crash. You should probably take a look at the head of the xfce-4.6 branch and see what needs to be done, if anything.
The first hunk is still applicable, because session_client->session_connection can still be zero inside the disconnect() helper. Second hunk isn't needed anymore.
Ok... can you attach a new patch?
Created attachment 2631 libxfcegui4: fix SEGV inside disconnect() helper This is the remainder that is needed after the recent rework of session-client.c [1]. [1] http://git.xfce.org/xfce/libxfcegui4/commit/?h=xfce-4.6&id=caffa2a1e66f44d63ea201f186d5fd0c5337f4bf
Created attachment 2632 libxfcegui4: fix SEGV inside disconnect() helper Whoops, sorry, attached old improper patch with typo.
Checked in and pushed, thanks.
*** Bug 5941 has been marked as a duplicate of this bug. ***