! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Switch does not handle all cases (support for SVN 1.5)
Status:
RESOLVED: FIXED
Product:
Thunar-vcs-plugin
Component:
General

Comments

Description Pavol Rusnak 2009-03-09 10:25:03 CET
Created attachment 2223 
added 1.5 support + version checking

I encountered this bug while compiling SVN trunk of the plugin:

tsh-common.c: In function 'tsh_action_to_string':
tsh-common.c:487: error: enumeration value 'svn_wc_notify_exists' not handled in switch
tsh-common.c:487: error: enumeration value 'svn_wc_notify_changelist_set' not handled in switch
tsh-common.c:487: error: enumeration value 'svn_wc_notify_changelist_clear' not handled in switch
tsh-common.c:487: error: enumeration value 'svn_wc_notify_changelist_moved' not handled in switch
tsh-common.c:487: error: enumeration value 'svn_wc_notify_merge_begin' not handled in switch
tsh-common.c:487: error: enumeration value 'svn_wc_notify_foreign_merge_begin' not handled in switch
tsh-common.c:487: error: enumeration value 'svn_wc_notify_update_replace' not handled in switch

Seems that 1.5 enums are not handled. This could be avoided by adding

default:
   break;

at the end of the switch statement. While I was doing that I produced more comprehensive patch adding support for these values. You should probably change the strings to be more descriptive. I don't know exactly when these notices are emitted.
Comment 1 Peter de Ridder editbugs 2009-03-09 19:25:22 CET
In revision ... all svn api functions are changed to the 1.5 api, as are the enumeration lists. The plugin now requires libsvn 1.5 or newer.

No version checking is done. I haven't used the preprocessor flags as given in the patch. I'll keep them in mind and might backport to the older versions of libsvn, if this is needed.
Comment 2 Peter de Ridder editbugs 2009-03-09 19:27:09 CET
The revision is #6874 which I forgot to mention in the previous comment.

Bug #5070

Reported by:
Pavol Rusnak
Reported on: 2009-03-09
Last modified on: 2009-07-14

People

Assignee:
Peter de Ridder
CC List:
0 users

Version

Version:
unspecified

Attachments

added 1.5 support + version checking (1.85 KB, patch)
2009-03-09 10:25 CET , Pavol Rusnak
no flags

Additional information