simplify the background image dialog: - use one image list instead of 2. - replace "Single Image" and "Image List" with "pick yourself" and "random". If "pick yourself" you can select the image to display in the background out of the list, "random" will choose one out of the list for your. Use the standard file select widget for adding a new image or fix some bugs: - The thumbnails in the standard dialog are much larger and thus I can better choose which wallpaper I want to use. Wallpapers are hugh and a small preview doesn't help me to select one :/ - The custom widget uses white as background for the image preview instead of my gtkrc setting (ouch). Ideas: - double click on an Image in the image list could it open with its standard application. - the "del" key could remove a selected image from the list. Icons: - "Icon type" is not really descriptive, better use "Visible Icons" Please don't mail me directly but answer on the bugzilla. Thank you.
(In reply to comment #0) > simplify the background image dialog: > - use one image list instead of 2. Huh? There is only one. > - replace "Single Image" and "Image List" with "pick yourself" and "random". If > "pick yourself" you can select the image to display in the background out of > the list, "random" will choose one out of the list for your. "Random" is a good idea. Unfortunately we just froze strings last week, so this will have to wait. > Use the standard file select widget for adding a new image or fix some bugs: > - The thumbnails in the standard dialog are much larger and thus I can better > choose which wallpaper I want to use. Wallpapers are hugh and a small preview > doesn't help me to select one :/ Huh? If you click on the "+" button, it brings up the normal file selector widget with a preview pane. > - The custom widget uses white as background for the image preview instead of > my gtkrc setting (ouch). What custom widget? There are no custom widgets in the dialog. If there's something in there not following your gtkrc setting, then your gtkrc setting is wrong. > Ideas: > - double click on an Image in the image list could it open with its standard > application. No. This isn't an app launcher. It's there solely to select images. > - the "del" key could remove a selected image from the list. Good idea. > Icons: > - "Icon type" is not really descriptive, better use "Visible Icons" Strings are frozen. IMHO "Visible Icons" isn't a very good label either. > Please don't mail me directly but answer on the bugzilla. Thank you. There's no need to keep saying this. No one would do this anyway.
(In reply to comment #1) > (In reply to comment #0) > > simplify the background image dialog: > > - use one image list instead of 2. > > Huh? There is only one. > If I select "Single Image" the dialog shows a different list with wallpapers I can choose from (but cannot modify). Could it be I got an old version (but it says 4.5.93 with xfdesktop/xfconf --version)? If not I mean to replace both lists with one and select how you want to use this list (let it pick a random image or pick it yourself). > > - replace "Single Image" and "Image List" with "pick yourself" and "random". If > > "pick yourself" you can select the image to display in the background out of > > the list, "random" will choose one out of the list for your. > > "Random" is a good idea. Unfortunately we just froze strings last week, so > this will have to wait. Ok. > > Use the standard file select widget for adding a new image or fix some bugs: > > - The thumbnails in the standard dialog are much larger and thus I can better > > choose which wallpaper I want to use. Wallpapers are hugh and a small preview > > doesn't help me to select one :/ > > Huh? If you click on the "+" button, it brings up the normal file selector > widget with a preview pane. > > > - The custom widget uses white as background for the image preview instead of > > my gtkrc setting (ouch). > > What custom widget? There are no custom widgets in the dialog. If there's > something in there not following your gtkrc setting, then your gtkrc setting is > wrong. Mhm... this is weird. Only the wallpaper dialog shows a file dialog which uses a different way to display a thumbnail. Didn't encounter it before and I doubt that the GTK2 development team would implement 2 thumbnail widgets. Maybe time will tell more, it's only this dialog so I don't care that much. (And I use gtk 2.14, which you don't work for incase it makes a difference) > > Icons: > > - "Icon type" is not really descriptive, better use "Visible Icons" > > Strings are frozen. IMHO "Visible Icons" isn't a very good label either. Maybe "Visible (Desktop) Icons"? I found the label weird, because thanks to beta status the described option didn't do anything after I changed it so I searched for another option which would hide all thumbnails on the desktop. (But problem solved itself after some more changes) So I think it's nondescriptive or else I would have seen instantly that I encountered a bug instead of thinking that I played with the wrong option.
(In reply to comment #2) > (In reply to comment #1) > > (In reply to comment #0) > > > simplify the background image dialog: > > > - use one image list instead of 2. > > > > Huh? There is only one. > > > > If I select "Single Image" the dialog shows a different list with wallpapers I > can choose from (but cannot modify). Could it be I got an old version (but it > says 4.5.93 with xfdesktop/xfconf --version)? > > If not I mean to replace both lists with one and select how you want to use > this list (let it pick a random image or pick it yourself). Well the lists don't serve the same function. The "single image" list is meant to list a bunch of possibly-system-provided images that are stored in standard locations, so if you don't have a particular image in mind that you want to use, you can just pick one. If you do, you can add to the list. (The fact that this list doesn't remember stuff that you've added but haven't selected, and doesn't allow you to remove images from is unfortunately due to a lack of time to implement those features.) The "image list" list is a list of images that *you* have selected manually in order to have different images display on startup. The function of the two lists does not really overlap. > > > Use the standard file select widget for adding a new image or fix some bugs: > > > - The thumbnails in the standard dialog are much larger and thus I can better > > > choose which wallpaper I want to use. Wallpapers are hugh and a small preview > > > doesn't help me to select one :/ > > > > Huh? If you click on the "+" button, it brings up the normal file selector > > widget with a preview pane. > > > > > - The custom widget uses white as background for the image preview instead of > > > my gtkrc setting (ouch). > > > > What custom widget? There are no custom widgets in the dialog. If there's > > something in there not following your gtkrc setting, then your gtkrc setting is > > wrong. > > Mhm... this is weird. Only the wallpaper dialog shows a file dialog which uses > a different way to display a thumbnail. Didn't encounter it before and I doubt > that the GTK2 development team would implement 2 thumbnail widgets. Maybe time > will tell more, it's only this dialog so I don't care that much. (And I use gtk > 2.14, which you don't work for incase it makes a difference) Ah, I see what you mean. Well, there *is* no standard preview widget in gtk's file chooser dialog. Gtk provides hooks to allow applications to provide a preview, and Xfce has one (in libexo) that we use (or should be using) throughout Xfce. If you have a problem with that, file a bug with libexo's image preview widget. > > > Icons: > > > - "Icon type" is not really descriptive, better use "Visible Icons" > > > > Strings are frozen. IMHO "Visible Icons" isn't a very good label either. > > Maybe "Visible (Desktop) Icons"? I found the label weird, because thanks to > beta status the described option didn't do anything after I changed it so I > searched for another option which would hide all thumbnails on the desktop. > (But problem solved itself after some more changes) So I think it's > nondescriptive or else I would have seen instantly that I encountered a bug > instead of thinking that I played with the wrong option. A label with a parenthetical word is even worse. If you're having a functional problem with the control itself, please file a separate bug for that; it should work as advertised, and I haven't heard of problems with it.
xfdesktop4.11 has fixed these suggestions.