! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Can not toggle capture
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce4-mixer
Component:
Panel Plugin

Comments

Description Jarno Suni 2009-01-06 15:51:40 CET
If you choose mixer track to be e.g. 'Capture', you can not toggle capture by middle-clicking the plugin. I thinks it should work like this command (plus give visual information), respectively:
amixer set 'Capture' toggle
Comment 1 Jarno Suni 2009-01-06 15:55:03 CET
...for the selected sound card, of course.
Comment 2 Jannis Pohlmann editbugs 2009-02-01 23:37:37 CET
This is not a bug but a feature request. It'll not make it into 4.6 but I'm considering major changes in the UI of the panel plugin for 4.8.
Comment 3 Jarno Suni 2009-02-02 08:38:54 CET
I think I already fixed it by adding five lines of code, but I haven't been able to test it, yet. Does your reluctance not to make it into 4.6 depend of feature freeze or what?
Comment 4 Jarno Suni 2009-02-02 09:54:55 CET
(In reply to comment #3)
> I think I already fixed it by adding five lines of code

That code is supposed to show "muted" icon also when capture is set off; I use a script for actual toggling capture.
Comment 5 Jannis Pohlmann editbugs 2009-02-03 02:20:40 CET
(In reply to comment #3)
> I think I already fixed it by adding five lines of code, but I haven't been
> able to test it, yet. Does your reluctance not to make it into 4.6 depend of
> feature freeze or what?

Yes. Feature freeze means no new features. This isn't a bug. However, I have plans for a better panel plugin for 4.8.
Comment 6 Jarno Suni 2009-02-03 07:25:21 CET
I think it is a bug since toggle does not work for all available tracks by it.
Does it show, if such a track is set off? (I can't check it now for the new version, but the older version, which comes with Xfce 4.4, shows it the same way as it shows 0% volume.)
But don't take it like you should make capture tracks unavailable ;)
Comment 7 Jannis Pohlmann editbugs 2009-02-03 08:56:15 CET
The mixer plugin right now should mute the tracks but that doesn't seem to work. So apologies to you, the bug report is valid. Seems like capture tracks don't support muting at all. So I'll probably fix this by switching to toggling capture mode.
Comment 8 Jannis Pohlmann editbugs 2009-02-03 11:41:34 CET
This is fixed in revision 29442:

	* panel-plugin/xfce-mixer-plugin.c: Use the GstMixerTrack "label"
	  property instead of the struct member to access the name of a track.
	  Toggle record for capture tracks instead of trying to mute them.
	  Capture tracks don't support muting (bug #4777).
	* xfce4-mixer/xfce-mixer-track.c: Don't show the mute button for
	  capture tracks (follow up of bug #4777).

The icon may not be appropriate but that's something for after 4.6.

Bug #4777

Reported by:
Jarno Suni
Reported on: 2009-01-06
Last modified on: 2009-07-14

People

Assignee:
Jannis Pohlmann
CC List:
1 user

Version

Attachments

Additional information