! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce4-places-plugin icon size doesn't follow gtkrc hints
Status:
RESOLVED: FIXED
Product:
Xfce4-places-plugin
Component:
General

Comments

Description charlie-tca 2008-12-27 18:54:32 CET
This bug was originally filed on Ubuntu Launchpad as:
https://bugs.launchpad.net/ubuntu/+source/xfce4-places-plugin/+bug/226161

Because the places plugin is supposed to be placed next to the standard Xfce menu, it should follow the same hints for its icon sizes.

I have this line in my ~/.gtkrc-2.0 file:
 gtk-icon-sizes = "gtk-menu=22,16"

This makes the icons in my Xfce menus 22x22. (The 16 after the comma is for application menus and toolbars.)
I believe the places plugin should follow this hint as well.

ADDITIONAL FOLLOWUP INFORMATION from the original reporter:
I'm talking about the icons of the menu items inside the menu. The icons inside the xfce4-menu-plugin (for Settings, Accessories and Development) are 22x22 pixels. This size is taken from my ~/.gtkrc-2.0 file. The xfce4-places-plugin however ignores the ~/.gtkrc-2.0 file and the icons for my home folder, Wastebasket, Desktop and the File System are only 16x16 pixels.

There is an attachment at http://launchpadlibrarian.net/20741923/menus.png
Comment 1 Diego Ongaro 2009-03-04 05:02:25 CET
Yep, you're right. I'll fix this before the next release.
Comment 2 Diego Ongaro 2009-06-23 03:02:46 CEST
Does that configuration setting have any effect on Xfce 4.6 (or recent versions of gtk)? I don't see any icon sizes change as a result on Debian unstable or Ubuntu 9.04, while some do with Debian Lenny.
Comment 3 Erik Xian 2009-07-27 17:29:37 CEST
I have a feeling this has to do with line 568 of view.c:

        pb = xfce_themed_icon_load(bookmark->icon, 16);

It looks like it's loading the icons as 16×16 only; I changed that to 22 and recompiled it and now the icons there only show up as 22×22.
Comment 4 Diego Ongaro 2009-07-31 05:06:56 CEST
Ah, here's where the configuration setting went in 4.6 - XSETTINGS:
http://forum.xfce.org/index.php?topic=4676.0

Fixed in svn r7871.

I'd strongly suggest using a size with width=height (square), since applications differ in which one they use. I've chosen MAX(width, height) here to be consistent with GTK.

Bug #4744

Reported by:
charlie-tca
Reported on: 2008-12-27
Last modified on: 2010-11-09

People

Assignee:
Diego Ongaro
CC List:
3 users

Version

Version:
unspecified

Attachments

Additional information