! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xdt-commit: Fix detection of changed ChangeLog files, do not rely on grep -P,...
Status:
RESOLVED: FIXED
Product:
Xfce4-dev-tools
Component:
General

Comments

Description Alexander Toresson 2008-12-13 21:47:15 CET
Created attachment 2036 
xdt-commit patch

The following patch fixes the following problems in the current xdt-commit:

* It does not properly detect changed ChangeLog files in svn, it thinks all have always changed.
* It relies on grep -P being available, it is not available on at least Debian and Ubuntu. To fix this I invoke perl instead, as I couldn't find a way of performing the same thing with my grep.
* At least when committing multiple translation updates, it would simply concatenate the ChangeLog messages, yielding several identical messages. I prefix every ChangeLog message with the directory of the ChangeLog, so it would look like this, for example:

xfce4-panel/trunk/po:
	* sv.po: Swedish translation update (Daniel Nylander)
xfdesktop/trunk/po:
	* sv.po: Swedish translation update (Daniel Nylander)
etc

I imagine this would be the most controversial change this patch introduces. I imagine it could be improved further (to work well when committing from the same directory as the ChangeLog resides in; I imagine that would currently result in .: which is not very pretty).
Comment 1 Jannis Pohlmann editbugs 2009-02-17 16:00:24 CET
Patch applied in revision 29499:

        * scripts/xdt-commit: Replace grep -P with awk and thus make the
          script more portable. Properly detect changed ChangeLogs in SVN.
          This should get rid the empty lines when committing several
          changed ChangeLogs (bug #4716). Patch provided by Alexander
          Toresson.

As you can see I don't really like perl so I replaced it with awk which should be just as portable as perl. Please give it a try.
Comment 2 Steve Dodier-Lazaro editbugs 2015-02-16 21:16:17 CET
Marking as fixed as per Jannis' last comment.

Bug #4716

Reported by:
Alexander Toresson
Reported on: 2008-12-13
Last modified on: 2015-02-16

People

Assignee:
Jannis Pohlmann
CC List:
2 users

Version

Attachments

xdt-commit patch (1.17 KB, patch)
2008-12-13 21:47 CET , Alexander Toresson
no flags

Additional information