I upgraded from 4.4.2 to Hopper and discovered that two of my three volume-control keyboard shortcuts had stopped working: Ctrl+F9 still worked, but Ctrl+F10 and Ctrl+F12 were broken. It turns out this is because Ctrl+F(N) is the default config for switching to Workspace N. First off, it's very confusing that certain shortcuts from the Keyboard settings take precedence, while others from the Window Manager settings take precedence; I would expect one or the other to consistently be preferred. Secondly, the two settings dialogs (or an xfce-settings backend) should detect this situation and give the user a warning/error, as happens when you try to duplicate a setting in the Window Manager settings dialog alone. To fix this, I had to both clear Ctrl+F12 as a shortcut in the WM dialog, as well as set it again in the Keyboard dialog.
What's a "Hopper"? Funny, cuz this is the one and only case where the new keyboard shortcuts manager can't detect conflicts: when they're already set up. Boo.
(In reply to comment #0) > I upgraded from 4.4.2 to Hopper and discovered that two of my three > volume-control keyboard shortcuts had stopped working: Ctrl+F9 still worked, > but Ctrl+F10 and Ctrl+F12 were broken. It turns out this is because Ctrl+F(N) > is the default config for switching to Workspace N. > > First off, it's very confusing that certain shortcuts from the Keyboard > settings take precedence, while others from the Window Manager settings take > precedence; I would expect one or the other to consistently be preferred. Yeah, that's weird. But it's not 100% predictable, I suppose. Usually whatever starts first has priority. So if xfwm4 starts before xfce4-settings-helper, all it's shortcuts should work. If xfce4-settings-helper starts first, the overlapping xfwm4 shortcuts shouldn't work. If they both start at the same time and they grab the keybindings on the X11 level simultaneously then you can't predict. That's why we have the conflict dialogs. There's not really any other way to avoid overlapping keys. > Secondly, the two settings dialogs (or an xfce-settings backend) should detect > this situation and give the user a warning/error, as happens when you try to > duplicate a setting in the Window Manager settings dialog alone. This works fine if you use the GUI to define the shortcuts. If you migrate from 4.4, the migration script tries to restore your previous shortcuts but it can't handle this kind of conflict. It's not really a bug. > To fix this, I had to both clear Ctrl+F12 as a shortcut in the WM dialog, as > well as set it again in the Keyboard dialog. In 4.6rc2 you'll only need to fix one of the them. There was a bug in xfce4-settings and also xfwm4 which didn't clean up properly when you e.g. defined a shortcut in xfwm4 that was already defined in xfce4-settings. I'm marking this bug as invalid because so there's no real way to fix it. I admit that you do have a point though. For all systems without migrated settings or pre-definied keys (other than the default keys installed together with Xfce 4.6) everything should be fine.
I'd rather leave this open for a bit, as it's a nasty usability bug, and there's no obvious way to fix it aside from poking around in the settings dialog, which might not be the first thing someone thinks of. xfce4-settings-helper and/or xfwm4 should present an error dialog if it fails to grab any of its keys, and should offer to open up the corresponding settings dialog to allow you to re-select the shortcut. Of course, we're in string freeze for 4.6, but maybe we can do this for 4.6.1.
I guess you're right. There's nothing bad about being reminded of how you could do things better.
*** Bug 5102 has been marked as a duplicate of this bug. ***
*** Bug 4875 has been marked as a duplicate of this bug. ***
*** Bug 4625 has been marked as a duplicate of this bug. ***
-- GitLab Migration Automatic Message -- This bug has been migrated to xfce.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.xfce.org/xfce/xfce4-settings/-/issues/1. Please create an account or use an existing account on one of our supported OAuth providers. If you want to fork to submit patches and merge requests please continue reading here: https://docs.xfce.org/contribute/dev/git/start#gitlab_forks_and_merge_requests Also feel free to reach out to us on the mailing list https://mail.xfce.org/mailman/listinfo/xfce4-dev