! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Long session RestartCommand truncated
Status:
CLOSED: FIXED
Product:
Xfce4-session
Component:
General

Comments

Description George Garvey 2004-11-05 17:00:38 CET
Saved a session with 14 gnome-terminals on 8 workspaces. The gnome-terminal
RestartCommand is truncated. It is 2069 chars, and ends with
"Terminal,--working-dire".
Comment 1 Benedikt Meurer editbugs 2004-11-05 17:32:47 CET
Fixes in CVS, thanks.
Comment 2 George Garvey 2004-11-18 21:14:29 CET
This is not fixed in RC1. I just installed it about an hour ago, recreated the
situation shown below. Exited and saved the new session. Could not see any
difference from before. The session still does not restore properly. Terminals
have moved desktops, the RestartCommand is still truncated.
Comment 3 Benedikt Meurer editbugs 2004-11-18 23:28:34 CET
Can you do a

grep LINE_MAX /usr/include/*.h /usr/include/*/*.h

please.
Comment 4 George Garvey 2004-11-18 23:31:29 CET
Created attachment 106 
Result of requested grep
Comment 5 Benedikt Meurer editbugs 2004-11-18 23:35:27 CET
Ah, ok, your system headers already set LINE_MAX and in our code we had

#ifndef LINE_MAX
#define LINE_MAX 8k
#endif

which of course explains why you still have the same problem. :-)
I changed it to

#ifdef LINE_MAX
#undef LINE_MAX
#endif
#define LINE_MAX 8k

So, it should be finally fixed.
Comment 6 George Garvey 2004-11-18 23:38:44 CET
Please tell me which file that is, so I may check it without using CVS.
Comment 7 Benedikt Meurer editbugs 2004-11-19 01:02:34 CET
xfce4/libxfce4util/libxfce4util/xfce-rc-simple.c
Comment 8 George Garvey 2004-11-19 01:11:49 CET
Thank you. That is where I made the change. That fixes the truncation.

However, the session does not restore the same as it was when saved. Should I
open a new bug for that, or continue with it here? Technically, the truncation
has been fixed, so this is really a different issue.

In either case, I'll try to give you a way to reproduce the problem.
Comment 9 Benedikt Meurer editbugs 2004-11-24 09:47:36 CET
Please file a new bug.

Bug #469

Reported by:
George Garvey
Reported on: 2004-11-05
Last modified on: 2009-07-14

People

Assignee:
Benedikt Meurer
CC List:
0 users

Version

Attachments

Result of requested grep (1.10 KB, text/plain)
2004-11-18 23:31 CET , George Garvey
no flags

Additional information