! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Display information about crypto-container when asking for the passphrase
Status:
RESOLVED: INVALID
Severity:
enhancement
Product:
Thunar-volman
Component:
General

Comments

Description Yves-Alexis Perez editbugs 2008-11-28 07:18:02 CET
Hi,

I recently tested an usb key with multiple luks container on it. thunar-volman correctly asked me all the passphrases, but without any information on for which container it was. So it's a bit confusing. It'd be nice to provide some information (even the device if this is the only thing available).

Cheers,
Comment 1 Colin Leroy 2008-11-28 07:48:24 CET
Created attachment 2004 
Display device file in mount dialog.

This patch does that. We have no other information than device file. Dialogs now look like:

Volume /dev/sdb2 is encrypted.
Please enter your password to decrypt
and mount the volume /dev/sdb2.

Wrong password.
Please enter your password to decrypt
and mount the volume /dev/sdb2.

Mounting /dev/sdb2...
Setting up the crypto layer...
Comment 2 Colin Leroy 2008-11-28 08:00:15 CET
(In reply to comment #1)
> Created an attachment (id=2004) [details]
> Display device file in mount dialog.
> 
> This patch does that. 

Oh, and the two extra hunks about g_set_error fix -Werror build on gcc 4.3.2.
Comment 3 Colin Leroy 2008-11-28 08:01:19 CET
Cc: ing Brian, as he's the one who handled the previous related patch.
Comment 4 Yves-Alexis Perez editbugs 2008-11-28 08:23:12 CET
Thanks!! Not sure if the feature and/or string freeze applies to thunar-volman. I'll test it this weekend and think I'll include it in Debian package anyway.
Comment 5 Colin Leroy 2008-12-03 10:06:08 CET
Adding possible commiters to Cc:
Comment 6 Colin Leroy 2008-12-03 11:55:57 CET
Adding possible commiters to Cc: (part 2)
Comment 7 Yves-Alexis Perez editbugs 2009-06-02 12:42:45 CEST
Jannis, could you commit that patch in thunar-volman?

Tia,
--
Yves-Alexis
Comment 8 Colin Leroy 2010-03-10 11:04:32 CET
Could anyone commit that ?
Comment 9 Sebastian Krämer 2011-05-30 11:32:12 CEST
I think the name was displayed correctly for some time but now it's back to 'xxGB drive something'. Actually, I think it was the same in gnome, so is there another (shared) component that needs fixing?
Anyway, I'd appreciate a better display in the passphrase dialogue in any case so if that's possible from within xfce, that'd be great.
Comment 10 Yves-Alexis Perez editbugs 2011-05-30 13:53:06 CEST
Note that with Xfce 4.8, thunar-volman is not responsible anymore for decrypting volumes.
Comment 11 Harald Judt editbugs 2015-02-26 17:30:32 CET
Closing. Please reopen if reproducible on an up-to-date system.

Bug #4656

Reported by:
Yves-Alexis Perez
Reported on: 2008-11-28
Last modified on: 2015-02-26

People

Assignee:
Jannis Pohlmann
CC List:
5 users

Version

Version:
unspecified

Attachments

Additional information