! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
too many open() for icons
Status:
RESOLVED: FIXED
Product:
Xfce4-panel
Component:
Launcher

Comments

Description Yves-Alexis Perez editbugs 2008-11-14 06:19:15 CET
Trying to help squisher on #xfce-dev I ran strace -eopen -p $(pidof xfce4-panel) and noticed that while I was hovering on a launcher icon, it was opening it constantly:

07:18:10 open("/usr/share/icons/Tango/32x32/apps/system-file-manager.png", O_RDONLY) = 9
07:18:10 open("/usr/share/icons/Tango/32x32/apps/system-file-manager.png", O_RDONLY) = 9
07:18:10 open("/usr/share/icons/Tango/32x32/apps/system-file-manager.png", O_RDONLY) = 9
07:18:10 open("/usr/share/icons/Tango/32x32/apps/system-file-manager.png", O_RDONLY) = 9
07:18:11 open("/usr/share/icons/Tango/32x32/apps/system-file-manager.png", O_RDONLY) = 9
07:18:11 open("/usr/share/icons/Tango/32x32/apps/system-file-manager.png", O_RDONLY) = 9
07:18:11 open("/usr/share/icons/Tango/32x32/apps/system-file-manager.png", O_RDONLY) = 9
07:18:11 open("/usr/share/icons/Tango/32x32/apps/system-file-manager.png", O_RDONLY) = 9
07:18:12 open("/usr/share/icons/Tango/32x32/apps/system-file-manager.png", O_RDONLY) = 9
07:18:12 open("/usr/share/icons/Tango/32x32/apps/system-file-manager.png", O_RDONLY) = 9
07:18:12 open("/usr/share/icons/Tango/32x32/apps/system-file-manager.png", O_RDONLY) = 9
07:18:12 open("/usr/share/icons/Tango/32x32/apps/system-file-manager.png", O_RDONLY) = 9
07:18:12 open("/usr/share/icons/Tango/32x32/apps/system-file-manager.png", O_RDONLY) = 9
07:18:12 open("/usr/share/icons/Tango/32x32/apps/system-file-manager.png", O_RDONLY) = 9

I'm not sure it's panel or gtk, but I guess there's something wrong there. The icon doesn't change, so there's no real need to open it again and again. That's not really serious because you don't spend your day hovering the icons, but it's still weird.

Cheers, and thanks for the time.
Comment 1 Nick Schermer editbugs 2008-11-14 06:35:37 CET
It's caused by the new gtk tooltip framework. It's not a big problem to cache the tooltip pixbuf. I discovered this about a week ago, will provide a fix this weekend.
Comment 2 Yves-Alexis Perez editbugs 2008-11-14 07:46:58 CET
Ok, sorry for the mess on bug #2502.

I paste the text here for the record:

In fact it seems this is the tooltip icon (which is opened even when not
displayed, because the tooltip comes a bit later).

The launcher icon is the 16px one which doesn't appear here (I have a size 20
panel).

Btw do you know how the choice is made between svg and png? Who does it? panel,
libxfcegui4, gtk?

Cheers,
Comment 3 Nick Schermer editbugs 2008-11-14 09:24:32 CET
This bug will only be fixed in the 4.6 branch, since there will be no 4.4 releases anymore.

The icon choice is made by gtk, but you have some kind of control. Mostly a (if possible) larger icon is returned, so there is code to scale it down to the required size in the laucher, but < 32px no svg icons are used, resulting in blurred icons on some panel sizes.
Comment 4 Yves-Alexis Perez editbugs 2008-11-14 10:04:20 CET
(In reply to comment #3)
> This bug will only be fixed in the 4.6 branch, since there will be no 4.4
> releases anymore.

I was testing on Hopper anyway.
> 
> The icon choice is made by gtk, but you have some kind of control. Mostly a (if
> possible) larger icon is returned, so there is code to scale it down to the
> required size in the laucher, but < 32px no svg icons are used, resulting in
> blurred icons on some panel sizes.

Is there a way to use svg icons at <32px or is this a limitation in gtk?
Comment 5 Nick Schermer editbugs 2008-11-15 10:17:33 CET
Fixed in revision 28806.

Bug #4614

Reported by:
Yves-Alexis Perez
Reported on: 2008-11-14
Last modified on: 2010-02-27

People

Assignee:
Nick Schermer
CC List:
0 users

Version

Version:
4.7 (master)

Attachments

Additional information