! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Workspace margins in dual monitor setup (patch available)
Status:
RESOLVED: FIXED

Comments

Description Christoph Trassl 2008-11-13 21:02:50 CET
When using two monitors, the workspace margin setting is not applied to the margin between the monitors, the margin settings are only applied to the outer edges. Looks much nicer when the margin is applied to every monitor.

I don't have a working 4.4.3 installation here, but I assume it is not addressed according to the release notes. Is this going to be addressed in 4.6?

If you mind, I have a patch ready for review that resolves the issue. Unfortunately not at hand atm.
Comment 1 Olivier Fourdan editbugs 2008-11-13 21:32:21 CET
I guess you're talking about Xinerama. Actually, I am not sure this is really suitable so this is why this was (the margins mimic the struts of EMWH which work like that).

Plus, margins are somehow... kinda... abandoned imho, this is something I added in 4.0 because I thought it was nice but I am not so sure about it now.

Of course, if you have a patch available (preferably against trunk), please attach it, I'll be glad to review it.
Comment 2 Christoph Trassl 2008-11-13 21:45:05 CET
Yes, you are right, I am talking about Xinerama.

Sorry to hear that margins are kindof abandoned: I use them to have a small border around maximised windows, so that the panels (which unfortunately can't autohide completely) do not overlap the window borders, which in turn does not look nice if you have small colored borders.

So I have a +1 for workspace margins or a +1 for hiding panels completely.

When I have the patch at hand I'll try to adapt it to trunk - if I fail, I'll attach the 4.4.2/4.4.3 version.
Comment 3 Christoph Trassl 2008-11-16 02:50:52 CET
Created attachment 1981 
Apply margins with respect to every screen (eg in Xinerama setup)
Comment 4 Christoph Trassl 2008-11-16 02:52:36 CET
The patch applied (with fuzziness) to trunk.

If there are problems I would be glad to review, eg if there are problems with three monitor setup, which I did not consider at the time I did the patch.
Comment 5 Steve Dodier-Lazaro editbugs 2015-02-16 21:23:52 CET
Thanks for the patch, closing this fixed report.

Bug #4610

Reported by:
Christoph Trassl
Reported on: 2008-11-13
Last modified on: 2015-02-16

People

Assignee:
Olivier Fourdan
CC List:
1 user

Version

Attachments

Additional information