! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
RC-file processing error
Status:
RESOLVED: INVALID
Severity:
critical
Product:
Xfce4-datetime-plugin
Component:
General

Comments

Description Eygene Ryabinkin 2008-11-03 08:34:30 CET
Created attachment 1949 
Patch that fixes the rc-file reading issue

It is plain wrong to perform g_strdup() after call to xfce_rc_close: returned pointer can be invalidated.  So we do g_strdup() early and aren't relying on the fact that xfce_rc_read_entry() will return the different pointers after successive invocations.

I had been able to really catch this only on FreeBSD/amd64, but I think it is just because of the memory management specifics on 64-bit machines.  This issue should hit i386 and others too.

The attached patch fixes the things for me.
Comment 1 Diego Ongaro 2008-11-03 08:48:07 CET
Unfortunately, you're a bit late: I noticed and fixed this in trunk in September.
http://svn.xfce.org/index.cgi/xfce-goodies/revision/?rev=5484

I'll do a new release when I have the time.

-Diego

Bug #4562

Reported by:
Eygene Ryabinkin
Reported on: 2008-11-03
Last modified on: 2010-11-09

People

Assignee:
Diego Ongaro
CC List:
1 user

Version

Version:
unspecified

Attachments

Patch that fixes the rc-file reading issue (1.84 KB, patch)
2008-11-03 08:34 CET , Eygene Ryabinkin
no flags

Additional information