! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
“Enable power save on battery power”
Status:
CLOSED: FIXED
Severity:
enhancement
Product:
Xfce4-power-manager
Component:
General

Comments

Description Yves-Alexis Perez editbugs 2008-10-19 17:29:04 CEST
This text on the battery tab is kind of weird, I'm not sure I understand the signification. When I hover the checkbox, a tooltip says me it's not supported on my platform (and I can't select it, anyway, it's greyed out), but I don't know what it is. Maybe it'd be a good idea to show a little help text?
Comment 1 Ali Abdallah editbugs 2008-10-20 07:27:53 CEST
I didn't understand exactly what you are talking about, is the checkbox for the power save in the battery tab ?
Comment 2 Yves-Alexis Perez editbugs 2008-10-20 08:18:18 CEST
(In reply to comment #1)
> I didn't understand exactly what you are talking about, is the checkbox for the
> power save in the battery tab ?

Yes, first checkbox, between “When battery charge is critical, do…“ and “Enable battery state notification“
Comment 3 Ali Abdallah editbugs 2008-10-20 08:24:57 CEST
(In reply to comment #2)
> Yes, first checkbox, between “When battery charge is critical, do…“ and “Enable
> battery state notification“

I see, actually the power manager test the method SetPowerSave using the current 
power_management.is_powersave_set value to check if we can send such event when running on battery if not we just disable it, i'll try to be more clear in this checkbox.
Comment 4 Yves-Alexis Perez editbugs 2008-10-20 08:30:57 CEST
(In reply to comment #3)
> (In reply to comment #2)
> > Yes, first checkbox, between “When battery charge is critical, do…“ and “Enable
> > battery state notification“
> 
> I see, actually the power manager test the method SetPowerSave using the
> current 
> power_management.is_powersave_set value to check if we can send such event when
> running on battery if not we just disable it, i'll try to be more clear in this
> checkbox.

Hmhm, but I don't even know what it is :)
Comment 5 Ali Abdallah editbugs 2008-10-21 09:34:29 CEST
SetPowerSave using the  current  power_management.is_powersave_set
Comment 6 Yves-Alexis Perez editbugs 2008-10-21 09:53:11 CEST
Yes but *what* is SetPowersave or power_management.is_powersave_set

I don't know, and I would assume the regular user won't either. So it may be a good idea to show a little help on this.
Comment 7 Ali Abdallah editbugs 2008-10-21 09:58:58 CEST
(In reply to comment #6)
> Yes but *what* is SetPowersave or power_management.is_powersave_set
> 
> I don't know, and I would assume the regular user won't either. So it may be a
> good idea to show a little help on this.

Not sure if i'll keep this option, since we are managing cpu, dpms and screen luminosity, so what hal setpowersave methods can do more!
Comment 8 Yves-Alexis Perez editbugs 2008-10-21 10:54:20 CEST
(In reply to comment #7)
> Not sure if i'll keep this option, since we are managing cpu, dpms and screen
> luminosity, so what hal setpowersave methods can do more!

I don't get it. What this option supposed to do, in the end? Is it a global stuff to put all components (cpu/dpms/screen lum) in a low-power state?
Comment 9 Ali Abdallah editbugs 2008-10-21 10:58:31 CEST
(In reply to comment #8)
> I don't get it. What this option supposed to do, in the end? Is it a global
> stuff to put all components (cpu/dpms/screen lum) in a low-power state?

No it's not a global option, it's a method in hal see org.freedesktop.Hal.Device.SystemPowerManagement.method_names.

It depends on the script hal-system-power-set-power-save-linux wish uses a util to do a full powersave like pm-powersave. but i'm not sure if i'll keep this option.
Comment 10 Ali Abdallah editbugs 2008-10-23 06:23:03 CEST
Fixed in svn. we don't show this check box at all if no powersave method is supported by HAL.
Comment 11 Ali Abdallah editbugs 2009-07-02 14:04:45 CEST
Closing old bugs to keep things organized.

Bug #4500

Reported by:
Yves-Alexis Perez
Reported on: 2008-10-19
Last modified on: 2009-07-14

People

Assignee:
Ali Abdallah
CC List:
0 users

Version

Version:
Unspecified

Attachments

Additional information