! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
add git support to xdt-commit
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
enhancement
Product:
Xfce4-dev-tools
Component:
General

Comments

Description Brian J. Tarricone (not reading bugmail) 2008-10-18 12:43:45 CEST 
Created attachment 1901 
git support for xdt-commit

Here's a patch to add git support to xdt-commit.  It works, though it's not quite so pretty.  What do you think?
Comment 1 Jannis Pohlmann editbugs 2008-10-18 12:57:29 CEST 
  MSG=$(git diff "${CHANGELOG}") 

in line 100 won't work. It has to be either

  MSG=$(git diff --cached "${CHANGELOG}")

or
 
  MSG=$(git diff HEAD "${CHANGELOG}")

Other than that this looks just fine.
Comment 2 Brian J. Tarricone (not reading bugmail) 2008-10-18 18:55:45 CEST 
Cool, thanks.  Checked in using HEAD; I want it to work properly regardless of whether or not the changelog has been "git add"ed or not after modifications.
Comment 3 Jannis Pohlmann editbugs 2008-10-18 18:59:30 CEST 
Yes, HEAD is the better of the two solutions.

Bug #4491

Reported by:
Brian J. Tarricone (not reading bugmail)
Reported on: 2008-10-18
Last modified on: 2009-07-14

People

Assignee:
Jannis Pohlmann
CC List:
0 users

Version

Version:
4.6.0
Target Milestone:
Xfce 4.6

Attachments

git support for xdt-commit (2.96 KB, patch)
2008-10-18 12:43 CEST , Brian J. Tarricone (not reading bugmail) 		no flags

Additional information