! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce-radio-plugin incorrectly truncates Russian characters
Status:
RESOLVED: FIXED
Product:
Xfce4-radio-plugin
Component:
General

Comments

Description pktfag 2008-09-07 19:28:33 CEST
Created attachment 1804 
corrected incorrect adding presets

When I try to add a new preset name, for example, "Наше радио" in russian, the program incorrectly truncates "Наше ра(some unexpectible character)." xfce4-plugin-radio code deals wrongly with UTF-8 encoding. For example, strncpy function is used to coping exactly MAX_PRESET_NAME_LENGTH bytes, but not characters. I replaced this and other functions as needed, but only where used variable MAX_PRESET_NAME_LENGTH. And now you can enter any number of characters, so I removed the restriction on the maximum number of characters.
See patch.
Comment 1 Stefan Ott 2008-09-16 03:26:06 CEST
Thanks, I'll have a look at this.
Comment 2 Stefan Ott 2008-11-30 04:20:04 CET
Fixed in SVN rev. 6228

Bug #4362

Reported by:
pktfag
Reported on: 2008-09-07
Last modified on: 2009-07-15

People

Assignee:
Stefan Ott
CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information