! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
[Wishlist]Use tumbler to generate thumbnails for images, pdf...


Description Jérôme Guelfucci editbugs 2008-09-01 08:54:07 CEST
It would be great if xfdesktop could use thunar to generate thumbnails for relevant files located on the desktop.
Comment 1 Eric Koegel editbugs 2011-12-05 16:17:19 CET
Created attachment 4005 
[PATCH] Thumbnail images!

This patch adds support for displaying thumbnails of images, so long as gtk supports the file format. As an added bonus the exif info is read and the orientation is set correctly.
I'm not an XFCE developer so please test this patch out and report any problems.
Comment 2 Eric Koegel editbugs 2011-12-06 16:58:48 CET
Created attachment 4006 
[PATCH] Displays thumbnails of images on the desktop. Sets up an  xfconf property so it can be disabled.

This patch fixes a bug in the previous patch I proposed where symbolic link emblems weren't rendered correctly. Additionally, there's an xfconf property to toggle displaying of thumbnails on the desktop. It can be changed with 'xfconf-query -c xfce4-desktop -p /desktop-icons/show-thumbnails -s true'. If the property doesn't exist this code also creates it, as a convenience.
Comment 3 Eric Koegel editbugs 2011-12-09 10:22:09 CET
Created attachment 4013 
xfdesktop uses tumbler to generate thumbnails

This patch allows xfdesktop to use tumbler to generate thumbnail files for any filetypes it supports. I've also made the code somewhat modular so that the xfdesktop-settings app could use the same code, but haven't messed with that yet. I'd also like to add functionality to use gtk as a fallback if tumbler isn't around or working properly.
Same deal as the last patch, there's an xfconf property to turn off thumbnail previews.
Since I'm not an XFCE dev, test this patch out and provide feedback please.
Comment 4 Eric Koegel editbugs 2011-12-09 12:22:41 CET
Created attachment 4014 
xfdesktop uses a dbus thumbnail service for icons

Bah! I missed a couple stupid bugs. This just improves and supersedes the last patch.
Comment 5 Eric Koegel editbugs 2011-12-17 08:23:01 CET
Created attachment 4027 
[PATCH] Adds support for drawing thumbnails from the dbus thumbnail service.

This patch adds the functionality to have the thumbnail service delete the thumbnail when the source file on the desktop is deleted so the user's thumbnail directory isn't filled with abandoned files. This patch also fixes a couple bugs I found while auditing and testing the code.
Comment 6 Eric Koegel editbugs 2011-12-24 18:45:52 CET
Created attachment 4041 
[PATCH] Adds support for drawing thumbnails from the dbus thumbnail service.

This revision fixes a bug on xfdesktop exit where  GLib-GObject-CRITICAL **: g_object_unref: assertion `object->ref_count > 0' failed.
Comment 7 Eric Koegel editbugs 2011-12-31 16:58:10 CET
Created attachment 4064 
Thumbnail desktop icons from tumblerd.

This patch changes how xfdesktop handles checking for the show-thumbnails option. Now changes to the option will get updated in real-time and with the previous patch if you disabled the thumbnails they'd still get generated even if you didn't ever use them. I also found a couple other minor things to tweak with the code.
Comment 8 Eric Koegel editbugs 2012-01-14 17:40:30 CET
Created attachment 4102 
[PATCH] Thumbnail desktop icons from tumblerd and display icon  tooltips

Fixed up some of the code and added support for displaying small icon previews on the tooltip popups.
Comment 9 Nick Schermer editbugs 2012-01-18 16:01:58 CET
This also needs an option to disable thumbnails, a lot of people use this in thunar too.
Comment 10 Nick Schermer editbugs 2012-01-18 16:02:31 CET
...Preferably checkbox in the dialog somewhere in the last tab.
Comment 11 Eric Koegel editbugs 2012-01-22 08:34:25 CET
Created attachment 4120 
[PATCH] Desktop icon previews from tumblerd

I added the option to toggle thumbnails to xfdesktop-settings.
Comment 12 Lionel Le Folgoc 2012-01-23 21:42:48 CET
Stupid question: why don't you keep the ratio of the original file? You seem to pass preserve_aspect_ratio=FALSE to gdk_pixbuf_new_from_file_at_scale(), so all thumbnails are squared right now.
Comment 13 Eric Koegel editbugs 2012-02-07 06:35:27 CET
Created attachment 4168 
[PATCH] Thumbnail desktop icon previews from tumblerd

The aspect ratio is now preserved, to do that I removed the
xfdesktop_icon_mark_extents_dirty function so that it would redraw the icons
correctly when the width or height changes.
Comment 14 Eric Koegel editbugs 2012-02-10 18:17:10 CET
Created attachment 4181 
[PATCH] Thumbnail desktop icon previews using tumblerd

  Setting the size of the tooltip image is a gtk style now so
"XfdesktopIconView::tooltip-size = 128" in the .gtkrc-2.0 will
allow the user to change it, 0 sets it to not show any image.
  Poll the thumbnail service to see if it supports large icons
and requests those to be created if they are. This way icons
and tooltip images larger than 128 look better.
  Changed the Icon Size spinner in the settings app to have a
timeout called so it can avoid redrawing all the icons for
every value change. The downsize is that it the user is
changing the icon size in xfconf-query or the Settings
Editor at the same time, then xfdesktop-settings won't see it
since it no longer binds to the value; xfdesktop still will
Comment 15 Jérôme Guelfucci editbugs 2012-02-13 08:18:09 CET
Hello Eric,

IMO bugs shouldn't be marked as fixed until the fix is committed to the git master branch and/or to a -4.x branch if relevant. That way, Resolved - Fixed means that it's fixed for real, ie if someone pulls the git master branch, the bug is not here.


Comment 16 Lionel Le Folgoc 2012-02-19 23:58:49 CET
*** Bug 8214 has been marked as a duplicate of this bug. ***
Comment 17 Nick Schermer editbugs 2012-02-20 08:07:36 CET
Closing the bugs is fine, we intend to merge this in master this week. So closing bugs makes it easier to find non-fixed bugs.

Bug #4344

Reported by:
Jérôme Guelfucci
Reported on: 2008-09-01
Last modified on: 2012-02-20
Duplicates (1):
  • 8214 Cannot display small jpgs or png files on screen. They appear as an icon (default for type)


Brian J. Tarricone (not reading bugmail)
CC List:
6 users



Additional information