! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Selected items in Settings manager have an unvisible caption
Status:
RESOLVED: FIXED
Severity:
trivial
Product:
Xfce4-settings
Component:
Settings Manager

Comments

Description Jérôme Guelfucci editbugs 2008-08-21 15:57:12 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.1) Gecko/2008072820 Firefox/3.0.1
Build Identifier: 

This happens with the latest trunk.

Reproducible: Always

Steps to Reproduce:
1. Open the Settings Manager
2. Click on an item to launch its dialog
3. Exit the dialog that just poped up.

Actual Results:  
The caption of the item you just clicked on is now unvisible, only the icon appears.
Comment 1 Christian Dywan 2008-08-25 00:05:04 CEST
Confirmed. Looks like a theming problem. There is no visible selection at all, which seems like if that were there it would work properly.
Comment 2 Brian J. Tarricone (not reading bugmail) 2008-08-25 02:10:12 CEST
Er, not sure what this means... you can't select the icons at all.  They're in single-click mode.  Or maybe my theme just doesn't show a selection color...
Comment 3 Jérôme Guelfucci editbugs 2008-08-25 06:41:41 CEST
By selected, I just meant clicked. I click on an item the dialog shows up, and at the same time the caption becomes unvisible. After closing the dialog, the captions remains unvisible until I click on another item.
Comment 4 Brian J. Tarricone (not reading bugmail) 2008-08-25 06:56:03 CEST
Ah, ok.  Yeah, definitely a theming thing.  Probably a problem with ExoIconView.
Comment 5 Nick Schermer editbugs 2008-08-25 07:55:17 CEST
No it's not (moving the bug back to xfce4-settings). It's a problem with Gtk text renderer which does not support "follow-state". It can be fixed by using a simplyfied version of the thunar text renderer which i've done in this [1] patch. It should be easy to extract the code from the patch.

Btw, exo_icon_view_set_text_column() is deprecated and internally it simply uses the gtk text renderer.

[1] http://foo-projects.org/~nick/patches/xfce4-settings-manager.patch
Comment 6 Brian J. Tarricone (not reading bugmail) 2008-08-25 08:58:33 CEST
(In reply to comment #5)
> No it's not (moving the bug back to xfce4-settings). It's a problem with Gtk
> text renderer which does not support "follow-state". It can be fixed by using a
> simplyfied version of the thunar text renderer which i've done in this [1]
> patch. It should be easy to extract the code from the patch.

Well that's super lame.  I'd rather add all that extra code just for something tiny like that.  The icons in the view should never be selected at all, anyway, so I'll just set the selection mode to GTK_SELECTION_NONE and be done with it.

> Btw, exo_icon_view_set_text_column() is deprecated and internally it simply
> uses the gtk text renderer.

Yes, well aware of that.  But why type out 5 lines of code when 1 will do, deprecated or not...?  ^_^  I guess might as well apply that part of your patch now at least.
Comment 7 Nick Schermer editbugs 2008-08-25 09:45:58 CEST
(In reply to comment #6)
> Well that's super lame.  I'd rather add all that extra code just for something
> tiny like that.  The icons in the view should never be selected at all, anyway,
> so I'll just set the selection mode to GTK_SELECTION_NONE and be done with it.

Well then you have to disable searching too... I agree it's stupid does not support this.

> 
> Yes, well aware of that.  But why type out 5 lines of code when 1 will do,
> deprecated or not...?  ^_^  I guess might as well apply that part of your patch
> now at least.

Now who thought that a few weeks ago ^_~. I've also switched to XfceRc, I'd say job well done ^_^.

Bug #4305

Reported by:
Jérôme Guelfucci
Reported on: 2008-08-21
Last modified on: 2009-07-14

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
5 users

Version

Attachments

Additional information