! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Deprecate XfceDesktopEntry in libxfce4util
Status:
RESOLVED: FIXED
Product:
Libxfce4util
Component:
General

Comments

Description Nick Schermer editbugs 2008-07-11 11:01:08 CEST
I think we should deprecate XfceDesktopEntry in libxfce4util. The code is only used in some places and XfceRc is much more powerful for reading data from .ini like files. It's also a bit confusing to provide 2 ways of reading desktop files in the same library.

For the time we could deprecate it and replace the internal code with GKeyFile (or XfceRc if we add a function to create a new XfceRc from data). This way we reduce the amount of code in libxfce4util to a minimum.
Comment 1 Nick Schermer editbugs 2009-10-19 10:43:31 CEST
Created attachment 2616 
Deprecate XfceDesktopEntry and use GKeyFile internally

There are no users of this code anymore, so I think we can deprecate it. Also cleaned the code by using GKeyFile internally, to saves a couple of lines.
Comment 2 Brian J. Tarricone (not reading bugmail) 2009-10-19 16:31:38 CEST
I'm fine with deprecating it, but there's no need to change the internal implementation.  Just leave it alone and migrate uses of it to XfceRc or GKeyFile... changing the impl will just create a new-bug risk for zero gain.
Comment 3 Nick Schermer editbugs 2009-10-20 11:09:08 CEST
Created attachment 2622 
Deprecate XfceMenuItem

Ok fine. Well the attached patch should do that, but it will break debug compilation of libxfcegui4, so I think we should drop gui4 out of the core components first before deprecating.
Comment 4 Nick Schermer editbugs 2010-10-27 20:54:28 CEST
Did this a while ago and fixed gui4 in master to compile with this.

Bug #4213

Reported by:
Nick Schermer
Reported on: 2008-07-11
Last modified on: 2010-10-27

People

Assignee:
Nick Schermer
CC List:
1 user

Version

Attachments

Deprecate XfceDesktopEntry and use GKeyFile internally (16.29 KB, patch)
2009-10-19 10:43 CEST , Nick Schermer
no flags
Deprecate XfceMenuItem (879 bytes, patch)
2009-10-20 11:09 CEST , Nick Schermer
no flags

Additional information