I think we should deprecate XfceDesktopEntry in libxfce4util. The code is only used in some places and XfceRc is much more powerful for reading data from .ini like files. It's also a bit confusing to provide 2 ways of reading desktop files in the same library. For the time we could deprecate it and replace the internal code with GKeyFile (or XfceRc if we add a function to create a new XfceRc from data). This way we reduce the amount of code in libxfce4util to a minimum.
Created attachment 2616 Deprecate XfceDesktopEntry and use GKeyFile internally There are no users of this code anymore, so I think we can deprecate it. Also cleaned the code by using GKeyFile internally, to saves a couple of lines.
I'm fine with deprecating it, but there's no need to change the internal implementation. Just leave it alone and migrate uses of it to XfceRc or GKeyFile... changing the impl will just create a new-bug risk for zero gain.
Created attachment 2622 Deprecate XfceMenuItem Ok fine. Well the attached patch should do that, but it will break debug compilation of libxfcegui4, so I think we should drop gui4 out of the core components first before deprecating.
Did this a while ago and fixed gui4 in master to compile with this.