! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Adjust brightness can't be set to 0
Status:
RESOLVED: WORKSFORME
Product:
Xfdesktop
Component:
General

Comments

Description trondsg 2008-05-15 16:29:18 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en; rv:1.8.1.7pre) Gecko/20070827 Epiphany/2.20 Firefox/2.0.0.4
Build Identifier: 

The desktop preferences has a slider called "Adjust brightness" that adjusts the brightness of the wallpaper. The default value is 0. Once you set it to something else it's impossible to get it back to 0 without using the keyboard or making the window wider and trying again. Casual users won't do either, and will be stuck with a setting they don't want.

Reproducible: Always

Steps to Reproduce:
1. Open the Desktop preferences
2. Set the brightness to something else than 0
3. Try to set the brightness to 0

Actual Results:  
Brightness ends up at 1 or -2.
Comment 1 Brian J. Tarricone (not reading bugmail) 2008-05-15 16:51:18 CEST
Works fine here.  I can easily select 0 with the mouse only after selecting a different value.  The window sizing (and thus the slider sizing) is dependent on your theme and font size.  Nothing I can do about this.
Comment 2 trondsg 2008-05-15 18:51:53 CEST
Can you select -2, -1 and 1 as well?
Comment 3 trondsg 2008-05-15 19:53:18 CEST
> Nothing ___I___ can do about this.
What does this mean? Are any of my possible interpreations correct?
1. You do not understand that this is relatively easy to fix
2. You do understand that it is fixable, but __you__ can't fix it, so you want _me_ to submit a patch?
3. You simply do not care, but will accept a patch just to stop the whining
4. You simply do not care, and will not accept a patch
5. Other?
Comment 4 Brian J. Tarricone (not reading bugmail) 2008-05-15 21:10:26 CEST
-1 doesn't work without a window resize.  Regardless, there's no way to fix this reliably across themes.
Comment 5 Brian J. Tarricone (not reading bugmail) 2008-05-15 21:13:19 CEST
(In reply to comment #3)
> > Nothing ___I___ can do about this.
> What does this mean? Are any of my possible interpreations correct?
> 1. You do not understand that this is relatively easy to fix
> 2. You do understand that it is fixable, but __you__ can't fix it, so you want
> _me_ to submit a patch?
> 3. You simply do not care, but will accept a patch just to stop the whining
> 4. You simply do not care, and will not accept a patch
> 5. Other?

No, it's simply not fixable.  Gtk sizes the slider.  This sizing depends on the gtk theme in use and the current font size, and probably other things.  The slider has 255 steps.  If fewer than 255 pixels are allocated for the slider trough, then some values won't be selectable by the mouse.  That's just how it is.
Comment 6 trondsg 2008-05-16 12:48:14 CEST
I unintentionally came across as way too harsh in my previous message. I hope you can overlook that.

The problem is this: It's not possible to select the default and sensible value of 0 using the mouse.
The standard solution to this problem is to replace the value label with a spin button. That won't fix the slider, but it solves the stated problem, as it's now possible to select 0 with the mouse.
Also, it goes from -50 to 50, right? (I'm on Windows now, so I can't test.) Then 100 steps should be enough. 255 is not needed.
Comment 7 Brian J. Tarricone (not reading bugmail) 2008-05-16 17:01:43 CEST
No, it goes from -127 to 128.  Or -128 to 127.  One of those.  Really, this isn't a big deal.  I'm not 'fixing' this.

Bug #4087

Reported by:
trondsg
Reported on: 2008-05-15
Last modified on: 2009-07-14

People

Assignee:
Brian J. Tarricone (not reading bugmail)
CC List:
0 users

Version

Attachments

Additional information