! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Compile warning: return' with no value
Status:
RESOLVED: FIXED
Product:
Xfce4-cpufreq-plugin
Component:
General

Comments

Description Bernhard Walle 2008-04-21 08:36:07 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; de; rv:1.9b5) Gecko/2008032600 SUSE/2.9.95-5 Firefox/3.0b5
Build Identifier: 

cpu-freq-monitor.c:53: warning: 'return' with no value, in function returning
non-void

and the source code is

 50                 if (!g_file_test (filePath, G_FILE_TEST_EXISTS))
 51                 {
 52                         g_free (filePath);
 53                         return;
 54                 }

and

 68                 if (!g_file_test (filePath, G_FILE_TEST_EXISTS))
 69                 {
 70                         g_free (filePath);
 71                         return;
 72                 }



Reproducible: Always

Steps to Reproduce:
Comment 1 Bernhard Walle 2008-04-21 08:37:44 CEST
Created attachment 1603 
Patch that fixes the compile error

I guess the timer should be aborted if the file does not exist. So returning FALSE makes sense here.
Comment 2 Florian Rivoal editbugs 2010-12-30 16:40:37 CET
This has been fixed, and will be ok in the next release.
Comment 3 Florian Rivoal editbugs 2010-12-30 16:41:55 CET
*** Bug 6022 has been marked as a duplicate of this bug. ***

Bug #4032

Reported by:
Bernhard Walle
Reported on: 2008-04-21
Last modified on: 2014-12-07
Duplicates (1):
  • 6022 missing includes and return values

People

Assignee:
Thomas Schreck
CC List:
2 users

Version

Version:
0.0.1 or older

Attachments

Patch that fixes the compile error (653 bytes, patch)
2008-04-21 08:37 CEST , Bernhard Walle
no flags

Additional information