! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Crash after closing the initial configure dialog when adding the plugin
Status:
CLOSED: FIXED
Product:
Xfce4-sensors-plugin
Component:
General

Comments

Description Enrico Tröger editbugs 2008-04-20 09:12:35 CEST
The current svn version of the plugin is unusable because once after the configure dialog is closed when adding the plugin to the panel, the plugin crashes due to a wrong default value for a string variable.
So you can't add the plugin to the panel because it instantly crashes at adding it.

Patch to solve the problem is attached.
Comment 1 Enrico Tröger editbugs 2008-04-20 09:14:10 CEST
Created attachment 1597 
Fix wrong initial value for sensors command by making a copy of the string instead of a constant string to fix crashes.
Comment 2 Enrico Tröger editbugs 2008-04-20 09:29:47 CEST
Just for your interest a few information I forgot in the previous post:

The crash happens in panel-plugin/sensors.c:2042:
g_free(sd->sensors->command_name);

And sd->sensors->command_name is initially set in panel-plugin/sensors.c:840:
sensors->command_name = "xsensors";

And free'ing a const string obviously causes a crash. The attached patch set sensors->command_name to a copy of the string which solves the problem.
Comment 3 Fabian Nowak editbugs 2008-06-27 18:38:29 CEST
(In reply to comment #2)

Thanks for the report, fixed it some weeks ago. Please close as resolved or patch applied. 

Comment 4 Enrico Tröger editbugs 2008-06-27 18:41:39 CEST
Fixed.

Bug #4030

Reported by:
Enrico Tröger
Reported on: 2008-04-20
Last modified on: 2009-07-15

People

Assignee:
Xfce-Goodies Maintainers
CC List:
1 user

Version

Version:
unspecified

Attachments

Additional information