! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Big Icons for the THUNAR toolbars ...
Status:
RESOLVED: INVALID

Comments

Description Andrea Antolini 2008-03-28 06:57:32 CET
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.13) Gecko/20080311 Firefox/2.0.0.13
Build Identifier: 

Recently I've updated on my system from gnome2.20 to gnome2.22.. after that I noticed a change in the icon size for THUNAR 0.9 when you select the toolbar style..

Normally Icons size I guess should be 24x24 while now they are probably 48x48..

I trie do recompile Thunar 0.9, libexo 0.3.4  but the problem still exist.

I don't understand which gnome 2.22 component (gtk-engines?, gnome-icon-theme?, gnome-themes? or anything else have influence on toolbar icon size)

e.g. Toolbar for Terminal 0.2.8 appears without correctly..

I've attacched a screeshoot to clarify better..

Reproducible: Always

Steps to Reproduce:
1.Open Thunar 0.9
2.Select Toolbar Style
3.Icons on toolbar are very big.. see screenshoot




Slackware 12
Kernel 2.6.24.4
GNome 2.22 compiled from scratch
GTK+ 2.12.9
Glib 2.16.1
Comment 1 Andrea Antolini 2008-03-28 06:58:09 CET
Created attachment 1574 
Thunar 0.9.0  big icons on toolbar
Comment 2 Andrea Antolini 2008-03-28 07:00:30 CET
Just another info.. I tried to start a gnome session using a new users created in this occasions to do some test and the issue still exist here with all default gnome settings...
Comment 3 Benedikt Meurer editbugs 2008-03-28 12:25:19 CET
Hm, the toolbar settings in Thunar are controlled by GTK, while Terminal does the toolbar size stuff on its own; so, as it seems, some part of your gnome update -- most probably GTK -- broke it. Did you check the standalone bulk renamer dialog? Is it messed up as well?
Comment 4 Andrea Antolini 2008-03-28 17:51:07 CET
I confirm that also thunar bulk rename utility has the same issue : icons are very big like in thunar toolbar..

fyi : I tried do downgrade to gtk+2.12.8 but issue still exists...

Bye Andrea
Comment 5 Andrea Antolini 2008-04-14 11:52:24 CEST
Someone opened a bug-report on UBUNTU regarding the sama issue : https://bugs.launchpad.net/ubuntu/+source/thunar/+bug/203236 

Bye Andrea
Comment 6 Andrew Starr-Bochicchio 2008-08-21 21:05:21 CEST
Created attachment 1783 
Patch by alextud

Patch by alextud (https://bugs.launchpad.net/~alextud) from LP bug.
Comment 7 Christian Dywan 2008-08-24 23:58:38 CEST
(In reply to comment #6)
> Created an attachment (id=1783) [details]
> Patch by alextud

The approach of the patch is wrong because it forces Thunar to use *small* icons in the toolbar while most applications default to *big* toolbar icons. And it will be impossible to change the size globally.

Without having more insight, this looks like a broken theme. I have seen themes with similar symptoms, where the theme specified wrong icon sizes and thus led to strange phenomenons like this, not only in Thunar.

The way Thunar creates the toolbar looks in no way wrong to me.
Comment 8 alextud 2008-09-14 21:38:01 CEST
I've installed thunar on three different computers (same distribution - ubuntu, x86 and x86_64) and on all systems toolbar icons are big. If I was a common user probably I'll stick with nautilus (icons are way to big for normal use).

I don't know why but file-roller is using same function to create toolbar gtk_ui_manager_get_widget () and icons aren't big like in thunar.

Normally toolbar is using only these two type of icons :  GTK_ICON_SIZE_SMALL_TOOLBAR and GTK_ICON_SIZE_LARGE_TOOLBAR 
but gtk_toolbar_get_icon_size (GTK_TOOLBAR(window->location_toolbar)) show value 6 == GTK_ICON_SIZE_DIALOG .

This may be a temporary fix :

 if (gtk_toolbar_get_icon_size (GTK_TOOLBAR(window->location_toolbar)) != GTK_ICON_SIZE_SMALL_TOOLBAR || gtk_toolbar_get_icon_size (GTK_TOOLBAR(window->location_toolbar)) != GTK_ICON_SIZE_LARGE_TOOLBAR)
 gtk_toolbar_set_icon_size (GTK_TOOLBAR(window->location_toolbar), GTK_ICON_SIZE_SMALL_TOOLBAR);
Comment 9 Jannis Pohlmann editbugs 2008-11-22 18:06:05 CET
I have another user reporting this issue. However, right now I don't see how this could be a bug in Thunar. Thunar just seems to create the toolbar using GtkUIManager and does no changes to the icon size at all.
Comment 10 jdagostino1 2008-11-28 02:33:54 CET
Hey, I've started getting this bug as well, but I've noticed that it only happens when gnome-settings-manager is running. If I'm not running gnome-settings-manager (for instance, in an xfce session, where I'm running xfce-mcs-manager instead, or in a fluxbox session where no settings manager is running) the toolbars are fine. 

I'm no GTK guru, so I don't know exactly what's wrong, but is Gnome setting some option that screws up Thunar? The way it is right now, Thunar works fine unless you're using Gnome, in which case it's unusable.
Comment 11 Simon Dalsgaard 2009-05-29 19:10:18 CEST
I have the same problem, since I also use Gnome. Any idea what is making this happening?
Comment 12 Maia Kozheva 2009-12-05 10:49:08 CET
Same here when using Thunar under GNOME, Ubuntu Karmic. Patch works for me.
Comment 13 Andrea Antolini 2010-06-09 21:20:19 CEST
Hi everybody.. any news about this annoying bugs? 

I confirm that bug is still present with Thunar 1.02 and gnome 2.30 (Gtk 2.20.x)

Just to clarify I confirm that the bugs is present only if you execute Thunar (or the BULK rename utility installed with Thunar) as standalone app, inside then Gnome environment.. If you run Thunar inside XFCE enviroment everything is fine..

I don't use the patch (I see is for Thunar 0.9.0).. then is there any chance to solve the issue?

thanks
Andrea
Comment 14 alextud 2010-06-09 21:52:19 CEST
Please look at your current theme configuration file and try to play with values for the following option:
gtk-icon-sizes

Configuration file is placed in: ~/.themes/"_your_current_gtk_theme"/gtk-2.0

I played  with this setting a few months ago and I've got correct icon size for thunar.

These are values that I'm using write now:
gtk-icon-sizes = "gtk-menu=16,16:\ngtk-button=22,22:\ngtk-dnd=22,22:\npanel-menu=16,16:\npanel=22,22:\ngtk-dialog=22,22:\ngtk-small-toolbar=22,22:"

Let me now that it work for you.

PS: Try to change to different theme and back to current one for reloading modified values.
Comment 15 Andrea Antolini 2010-06-10 16:01:30 CEST
@ alextud :  ... your suggestion works fine (at least for me) and finally toolbars icons in Thunar are ok :)

(..and it works also adding the gkt-icon-sizes option with your value in the 
$HOME/.gtkrc-2.0  file , so in this way the setting for that options is valid for all gtk themes ;-) 


Thanks a lot..
Andrea
Comment 16 Andrea Antolini 2010-06-10 16:32:06 CEST
(In reply to comment #15)
> (..and it works also adding the gkt-icon-sizes option with your value in the 
> $HOME/.gtkrc-2.0  file , so in this way the setting for that options is valid
> for all gtk themes ;-) 

just a clarification...:)

 my suggestion doesn't work if a gtk-icon-sizes option is already defined with a different value , in the ~/.themes/"_your_current_gtk_theme"/gtk-2.0/gtkrc file..



Andrea
Comment 17 computermacgyver 2011-11-13 02:22:31 CET
The workaround solution no longer works on gnome3 as gtk-2.0rc doesn't exist. However, the problem still exists. Any idea on how to translate this to  ~/.config/gtk-3.0/settings.ini or ~/.config/gtk-3.0/gtk.css ?

I'm still experiencing the issue on ubuntu 11.10 running the gnome3 fallback.

Many thanks!
Comment 18 Nick Schermer editbugs 2012-09-26 16:21:46 CEST
Closing this, not a Thunar issue.
Comment 19 Nick Schermer editbugs 2012-10-29 21:52:56 CET
1.5.1 will have a hidden property misc-small-toolbar-icons, if set to true GTK_ICON_SIZE_SMALL_TOOLBAR will be set.

Bug #3971

Reported by:
Andrea Antolini
Reported on: 2008-03-28
Last modified on: 2012-10-29

People

Assignee:
Jannis Pohlmann
CC List:
8 users

Version

Version:
unspecified

Attachments

Thunar 0.9.0 big icons on toolbar (301.98 KB, image/jpeg)
2008-03-28 06:58 CET , Andrea Antolini
no flags
Patch by alextud (817 bytes, patch)
2008-08-21 21:05 CEST , Andrew Starr-Bochicchio
no flags

Additional information