Removable volumes like USB sticks are automatically added to the desktop when plugged in. Accessing the drive through Thunar will automount it. After closing Thunar it's no longer clear if a drive is mounted or not (and thus save to remove or not) without right clicking the icon. Adding an emblem to the drive icon to show the current mount state would greatly enhance usability.
I think this is a duplicate of (or related to) bug 6281.
Created attachment 4015 This adds an emblem to the volume icon to show when it's mounted. I couldn't figure out exactly which icon should be used as the emblem so "emblem-generic" it is. If there's a better emblem for the job let me know. I also added a simple internal helper function to figure out if the volume has something mounted on it.
Maybe we can make the icon 50% transparent, using exo_gdk_pixbuf_lucent. That is also what thunar does.
Created attachment 4110 [PATCH] Unmounted volumes are semi-transparent A semi-transparent icon looks a lot less ugly than that emblem, changed.
exo_gdk_pixbuf_lucent return a new object, so you need to do this: if(!xfdesktop_volume_icon_is_mounted(icon)) { lucent = exo_gdk_pixbuf_lucent(file_icon->priv->pix, 50); g_object_unref (file_icon->priv->pix); file_icon->priv->pix = lucent; }
Created attachment 4111 [PATCH] Unmounted volumes are semi-transparent Heh, I noticed that right after I submitted the patch but you still beat me to it.
Looks ok now.
Added to eric/bugzilla branch for testing, http://git.xfce.org/xfce/xfdesktop/commit/?h=eric/bugzilla-patches&id=0af2c17f9ff3f3a64da7bc3f07ce06cf6bb107fc
Committed to Master: http://git.xfce.org/xfce/xfdesktop/commit/?id=0af2c17f9ff3f3a64da7bc3f07ce06cf6bb107fc