! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
LCD clock widget doesn't redraw correctly
Status:
RESOLVED: FIXED
Product:
Xfce4-panel

Comments

Description Enrico Tröger editbugs 2008-03-23 13:45:38 CET
It's hard to describe but the LCD clock plugin sometimes seem just to paint over the old widget content instead of clearing it first.
Once I move the mouse cursor somewhere over the panel, it gets redrawn and looks like it should.

GTK 2.12.9
Pango 1.20.0
Cairo 1.4.14
Comment 1 Enrico Tröger editbugs 2008-03-23 13:46:15 CET
Created attachment 1570 
Redraw problem with LCD panel clock
Comment 2 Enrico Tröger editbugs 2008-03-23 13:46:27 CET
Created attachment 1571 
Redraw problem with LCD panel clock
Comment 3 Nick Schermer editbugs 2008-08-02 14:57:01 CEST
Well it more like requesting a draw for the entire widget, which also clears the entire widget area. So we probably draw outside the plugin area which is possible with internal plugins.

I've added 1px to the requested width which should prevent the rounding errors, because that probably the 1px you see. Committed in revision 27417.

Closing bug, please reopen if you can still reproduce it.
Comment 4 Enrico Tröger editbugs 2008-08-03 14:27:58 CEST
Unfortunately, there is no change at all :(.
Comment 5 Nick Schermer editbugs 2008-08-03 17:57:27 CEST
Meh, will take a look at it later this week.
Comment 6 Enrico Tröger editbugs 2008-08-03 18:51:22 CEST
Tell me if I can help you in any way.
Comment 7 Nick Schermer editbugs 2008-08-10 11:45:12 CEST
Should be fixed in trunk. Digits should also be a lot sharper on larger panels (ie. when a digit line >= 1px).

I can't reproduce the problem here, please reopen when you still see problems.
Comment 8 Nick Schermer editbugs 2008-08-10 11:52:37 CEST
Mm when seconds and am/pm are enabled there are still some drawing problems ;-).
Comment 9 Nick Schermer editbugs 2008-08-10 13:53:55 CEST
Enrico, could you try r27442? I think most stuff is fixed, although in some situations the digits could be a bit sharper/nicer but that's hard to achieve since there are so many size/orientation possibilities... 
Comment 10 Enrico Tröger editbugs 2008-08-10 14:52:50 CEST
I'm sorry to disappoint you again, but it still happens.

In case it helps, I'll attach my clock plugin config. Since I didn't mention this before but this happens with a vertical panel orientation.

And thanks so far for spending so much time for this issue.
Comment 11 Enrico Tröger editbugs 2008-08-10 14:53:26 CEST
Created attachment 1761 
Clock plugin config
Comment 12 Nick Schermer editbugs 2008-08-10 17:11:24 CEST
I saw in the screenshot you panel was vertical. Wat panel size do you have?
Comment 13 Enrico Tröger editbugs 2008-08-10 18:05:47 CEST
The size is 28.
Comment 14 Nick Schermer editbugs 2008-08-14 16:29:55 CEST
I think clipping the drawing area should work to prevent drawing outside the area. Could you try revision 27449?
Comment 15 Enrico Tröger editbugs 2008-08-16 15:01:27 CEST
Created attachment 1775 
Clock screenshot with SVN r27451
Comment 16 Enrico Tröger editbugs 2008-08-16 15:01:46 CEST
Created attachment 1776 
Clock screenshot with SVN r27451
Comment 17 Enrico Tröger editbugs 2008-08-16 15:02:00 CEST
Created attachment 1777 
Clock screenshot with SVN r27451
Comment 18 Enrico Tröger editbugs 2008-08-16 15:05:06 CEST
It's definitely better, the original problem is solved. But looking at the new screenshots, you can see the time is displayed completely but the boundaries aren't used completely and it seems there is still one pixel of the left and right boundaries missing.

Anyway, this is better than before, thanks a lot Nick.
Comment 19 Jos van Wolput 2009-02-24 06:38:17 CET
(In reply to comment #18)
> It's definitely better, the original problem is solved. But looking at the new
> screenshots, you can see the time is displayed completely but the boundaries
> aren't used completely and it seems there is still one pixel of the left and
> right boundaries missing.
> 
> Anyway, this is better than before, thanks a lot Nick.

Some now and then the LCD clock becomes very small. Changing one of the clock options redraws the right size.
I am using the latest svn version of the panel, with a panel size of 32 pixels.
Comment 20 Nick Schermer editbugs 2010-12-21 21:08:19 CET
Fixed a bunch of stuff in f24985b, please reopen if you still see issues.

Bug #3960

Reported by:
Enrico Tröger
Reported on: 2008-03-23
Last modified on: 2010-12-21

People

Assignee:
Nick Schermer
CC List:
2 users

Version

Version:
Unspecified

Attachments

Redraw problem with LCD panel clock (1.68 KB, image/png)
2008-03-23 13:46 CET , Enrico Tröger
no flags
Redraw problem with LCD panel clock (1.33 KB, image/png)
2008-03-23 13:46 CET , Enrico Tröger
no flags
Clock plugin config (166 bytes, application/octet-stream)
2008-08-10 14:53 CEST , Enrico Tröger
no flags
Clock screenshot with SVN r27451 (596 bytes, image/png)
2008-08-16 15:01 CEST , Enrico Tröger
no flags
Clock screenshot with SVN r27451 (1.36 KB, image/png)
2008-08-16 15:01 CEST , Enrico Tröger
no flags
Clock screenshot with SVN r27451 (544 bytes, image/png)
2008-08-16 15:02 CEST , Enrico Tröger
no flags

Additional information