! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Dragging non text/uri-list filenames to panel launcher doesn't work
Status:
CLOSED: FIXED
Product:
Xfce4-panel
Component:
Launcher

Comments

Description Enrico Tröger editbugs 2008-03-22 12:16:53 CET
Dragging of files from a file manager like thunar to panel launchers works fine. But it won't work for filenames dropped whose source is something like an editor or web browser. The launcher plugin only accepts text/uri-list but IMO it happens often that people are dragging other kinds of text to launchers like text/plain which just don't work.
Comment 1 Enrico Tröger editbugs 2008-03-22 12:19:46 CET
Created attachment 1569 
Allow other text formats for DnD than text/uri-list

This patch allows also "STRING", "UTF8_STRING" and "text/plain" as drop targets for the panel launcher and interprets the received data accordingly.

Note: there is probably a smarter way of checking the target type of the received data than comparing gdk_atom_name(selection_data->target and "text/uri-list" but for now it works.
Comment 2 Stefan Stuhr 2008-04-22 15:29:38 CEST
The launcher in Xfce 4.4 supports the "text/uri-list", "text/x-moz-url", and "STRING" targets.

In the case of text/x-moz-url, it apparently does some utf16 to utf8 conversion.
Comment 3 Nick Schermer editbugs 2008-06-26 10:50:58 CEST
I really don't see how this is a bug. Why would someone drop a string on the launcher that is an uri.
Comment 4 Stefan Stuhr 2008-06-26 21:16:26 CEST
(In reply to comment #3)
> I really don't see how this is a bug. Why would someone drop a string on the
> launcher that is an uri.
> 

Use cases:
* A user goes to a website (maybe a forum) where another user/the site owner has written an uri to anoter site, but as non-clickable text. The user wants to open it in a new window/tab, selects the uri text, and drag it to their web browser panel launcher. (Right now, in svn, one can't even drag clickable links from gecko browsers to a panel launcher).
* A program accepts all sorts of text (non-uri) as argument, and can do something with it (e.g. put it in the clipboard, or send a mail with the dragged text as content), and the user wants to use this feature in a panel launcher.
Comment 5 Nick Schermer editbugs 2008-06-27 05:37:06 CEST
O wait, that kinde drops, I though dropping .desktop files in the preferences window, my bad...
Comment 6 Nick Schermer editbugs 2008-08-01 20:21:22 CEST
Fixed with revision 27412
Comment 7 Enrico Tröger editbugs 2008-09-28 08:10:43 CEST
Thanks!

Bug #3958

Reported by:
Enrico Tröger
Reported on: 2008-03-22
Last modified on: 2010-11-20

People

Assignee:
Nick Schermer
CC List:
2 users

Version

Version:
Unspecified

Attachments

Additional information