User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b4) Gecko/2008031317 Firefox/3.0b4 Build Identifier: (An ubuntu user reported this bug at: https://bugs.launchpad.net/ubuntu/+source/xfdesktop4/+bug/202970) Xfdesktop has a little cosmetic issue when switching from "system font size" to "custom font size" in the settings manager. 1) I expect, that when in Applications -> Settings -> Settings manager -> Desktop -> Behavior I uncheck the "Use system font size" option, xfdesktop will use the size given in the "Custom font size" spinbox. 2) Instead of that, when I uncheck it first, it will use a size of 0px for the desktop icons' font size, so the text is unreadable (I will attach a screenshot with the checked and the unchecked state). 3) How to reproduce the bug? This problem only happens, if the "Custom font size" option never changed, because if a change happens, the xfce-mcs-manager will store the value of the font size, and when unchecking the "Use system font size" checkbox, xfdesktop will load the stored setting. But if is no stored setting, xfdesktop will use the 0px. 4) Possible solution (#1) Make xfce-mcs-manager store the value of the spinbox, when the spinbox change its state from insensitive to sensitive. (I think think this is the better solution.) The first source file (behavior-settings.c), that I will attach, contains this solution. 5) Possible solution (#2) Modify xfdesktop, to use a more sensible default value, such as 12px. The second source file (xfce-desktop-settings.c), that I will attach contains this solution. Reproducible: Always
Created attachment 1565 Proposed patch (#1)
Created attachment 1566 Proposed patch (#2) Here are the two patches proposed by the bug reporter.
Created attachment 1567 screenshot of the cosmetic issue
Created attachment 1568 screenshot of the cosmetic issue
I can confirm this bug report, I observe the same problem. There's another issue with Desktop font size. I think it is unrelated to this bug, and I have reported it in Bug 4295.
Your first patch looks a little overly complicated -- I would think all that would be necessary would be to set the default value unconditionally. Anyhow, new xfconf-based settings dialog for 4.6, and that doesn't seem to suffer from the same problem. Pretty low-prio for me to fix in 4.4 right now.
Sorry I didn't get back to this... much much simpler 3-line fix checked in. See here: http://svn.xfce.org/index.cgi/xfce/revision/?rev=28108