! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce-mcs-manager crashes when refreshed too frequently
Status:
RESOLVED: WONTFIX
Product:
Xfce-mcs
Component:
General

Comments

Description Yves-Alexis Perez editbugs 2008-01-13 21:58:07 CET
Currently, xfce-mcs-manager refresh itself when it receives a SIGUSR1. We use that in debian package to have it refresh itself when installing a new component, so user see the settings in settings manager as soon as the component is installed.

But when upgrading xfce, for example, we send SIGUSR1 to xfce-mcs-manager multiple time in short succession, and sometimes it gets completely killed, meaning the user doesn't have any Xsetting anymore (especially not its theme), no keybindings, etc.

I agree we don't do this the perfect way (we should have a way to refresh xfce-mcs-manager at the end, when every new component has been installed/upgraded) but we can't really do otherwise currently.
OTOH, xfce-mcs-manager signal handler isn't really reentrant, or something like that.

I cooked a patch wich makes x-m-m ignore SIGUSR1 when a SIGUSR1 is received (after the sighandler is ended). I'm not sure this patch is correct (maybe I should do that *in* the sighandler to be sure that there will be no window when another USR1 could be received), but I wanted to submit it as a RFC.

What do you think?
Comment 1 Yves-Alexis Perez editbugs 2008-01-13 21:58:53 CET
Created attachment 1491 
Make xfce-mcs-manager ignore USR1 when it has already received one
Comment 2 Brian J. Tarricone (not reading bugmail) 2008-01-14 00:55:07 CET
Should just backport the sighandler stuff from trunk and use that instead...
Comment 3 Yves-Alexis Perez editbugs 2008-01-14 07:46:04 CET
In the meanwhile, what you do think about this patch. Do you think it's safe to include it to our debian builds?
Comment 4 Brian J. Tarricone (not reading bugmail) 2008-01-14 08:11:58 CET
I think it should be ok, but don't quote me on it ^_~.
Comment 5 Yves-Alexis Perez editbugs 2009-07-15 18:00:37 CEST
xfce-mcs-manager is gone so I guess this one could be closed as wontfix or something like that.
Comment 6 Brian J. Tarricone (not reading bugmail) 2009-07-15 18:53:41 CEST
Yes, probably, unless someone feels like checking in the patch.  I doubt we'll do another 4.4.x release, so...
Comment 7 Yves-Alexis Perez editbugs 2010-08-05 06:28:17 CEST
MCS is gone.

Bug #3803

Reported by:
Yves-Alexis Perez
Reported on: 2008-01-13
Last modified on: 2010-08-05

People

Assignee:
Xfce Bug Triage
CC List:
0 users

Version

Attachments

Additional information