! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Refactor DND launcher code + 0install
Status:
RESOLVED: WONTFIX
Product:
Xfce4-panel
Component:
Launcher

Comments

Description Jasper Huijsmans editbugs 2007-12-28 16:38:37 CET
Here's a couple of patches that improve, I believe, the DND handling on the config dialog. 

It's a series of 4 patches:
1 - refactor dnd handling to separate module (launcher-dnd.c)
2 - add support for regular executables and non-executable files
3 - add support for 0install in separate module (launcher-dnd-0install.c)
4 - some fixes for the 0install support.

I know you don't really like 3/4, but apparently they did work and were used by people, so I think we should add it back.  As a reward to people sending patches ;-)

The patches have to be applied in order.

NOTE:
Patches were created with git. If you have a git repo you can use git-am to apply these. Otherwise, patch -p1 should work, although you may have to remove the headers.
Comment 1 Jasper Huijsmans editbugs 2007-12-28 16:40:08 CET
Created attachment 1480 
refactor dnd on config dialog
Comment 2 Jasper Huijsmans editbugs 2007-12-28 16:40:49 CET
Created attachment 1481 
add support for executable and regular files
Comment 3 Jasper Huijsmans editbugs 2007-12-28 16:41:13 CET
Created attachment 1482 
add support for 0install
Comment 4 Jasper Huijsmans editbugs 2007-12-28 16:41:46 CET
Created attachment 1483 
some improvements for 0install support
Comment 5 Nick Schermer editbugs 2008-08-02 15:11:18 CEST
You can commit the first 2 patches, but this whole 0install thing makes no sence to me. It's a ROX desktop thingy, lets keep it that way.
Comment 6 Nick Schermer editbugs 2009-03-23 08:18:20 CET
4.6 is bug fixes only, code does not apply on the 4.8 panel and no need for 0install in Xfce imho.

Bug #3771

Reported by:
Jasper Huijsmans
Reported on: 2007-12-28
Last modified on: 2010-02-27

People

Assignee:
Nick Schermer
CC List:
0 users

Version

Version:
4.7 (master)

Attachments

refactor dnd on config dialog (12.42 KB, patch)
2007-12-28 16:40 CET , Jasper Huijsmans
no flags
add support for executable and regular files (2.70 KB, patch)
2007-12-28 16:40 CET , Jasper Huijsmans
no flags
add support for 0install (11.87 KB, patch)
2007-12-28 16:41 CET , Jasper Huijsmans
no flags
some improvements for 0install support (2.71 KB, patch)
2007-12-28 16:41 CET , Jasper Huijsmans
no flags

Additional information