! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
won't compile on Suse10.0 x86_64
Status:
RESOLVED: FIXED
Product:
Xfce4-places-plugin
Component:
General

Comments

Description hellohello 2007-11-30 20:08:35 CET
User-Agent:       Opera/9.23 (X11; Linux x86_64; U; de)
Build Identifier: 

I can't compile it on Suse10.0 x86_64
The same messages comes on every version of places from 0.2 to 1.0

model_user.c:38: error: syntax error before 'time_t'
model_user.c:38: warning: no semicolon at end of struct or union
model_user.c:42: error: syntax error before '}' token
model_user.c: In function 'places_bookmarks_user_reinit':
model_user.c:58: error: dereferencing pointer to incomplete type
model_user.c:104: error: dereferencing pointer to incomplete type
model_user.c:106: error: dereferencing pointer to incomplete type
model_user.c: At top level:
model_user.c:113: error: syntax error before 'places_bookmarks_user_get_mtime'
model_user.c: In function 'places_bookmarks_user_get_mtime':
model_user.c:116: error: dereferencing pointer to incomplete type
model_user.c: In function 'places_bookmarks_user_init':
model_user.c:126: error: invalid application of 'sizeof' to incomplete type 'BookmarksUser'
model_user.c:129: error: dereferencing pointer to incomplete type
model_user.c:131: error: dereferencing pointer to incomplete type
model_user.c:132: error: dereferencing pointer to incomplete type
model_user.c:133: error: dereferencing pointer to incomplete type
model_user.c: In function 'places_bookmarks_user_changed':
model_user.c:143: error: 'time_t' undeclared (first use in this function)
model_user.c:143: error: (Each undeclared identifier is reported only once
model_user.c:143: error: for each function it appears in.)
model_user.c:143: error: syntax error before 'mtime'
model_user.c:145: error: 'mtime' undeclared (first use in this function)
model_user.c:145: error: dereferencing pointer to incomplete type
model_user.c:146: error: dereferencing pointer to incomplete type
model_user.c:147: error: dereferencing pointer to incomplete type
model_user.c:148: error: dereferencing pointer to incomplete type
model_user.c:158: error: dereferencing pointer to incomplete type
model_user.c:159: error: dereferencing pointer to incomplete type
model_user.c: In function 'places_bookmarks_user_visit':
model_user.c:175: error: dereferencing pointer to incomplete type
model_user.c:176: error: dereferencing pointer to incomplete type
model_user.c: In function 'places_bookmarks_user_finalize':
model_user.c:185: error: dereferencing pointer to incomplete type
model_user.c:186: error: dereferencing pointer to incomplete type
model_user.c:188: error: dereferencing pointer to incomplete type
model_user.c:189: error: dereferencing pointer to incomplete type
model_user.c:191: error: dereferencing pointer to incomplete type
make: *** [xfce4_places_plugin-model_user.o] Fehler 1

Reproducible: Always

Steps to Reproduce:
1.  ./configure
2.  make
3.




gtk2-2.8.10-50
xfce4-4.4.1-42.2 from http://download.opensuse.org/repositories/X11:/xfce/SUSE_Linux_10.0/x86_64/
Comment 1 Diego Ongaro 2007-12-01 00:17:59 CET
I just tried this on a virtualbox image of Suse 10.3, but could not reproduce the issue there (on 32-bit hardware). Please try to add the following two lines to the top of model_user.c in version 1.0.0 or trunk:
 #include <sys/types.h>
 #include <sys/stat.h>

Let me know how it goes (I certainly hope you check your @mytrashmail.com email...)
Comment 2 hellohello 2007-12-03 17:51:21 CET
(In reply to comment #1)
> I just tried this on a virtualbox image of Suse 10.3, but could not reproduce
> the issue there (on 32-bit hardware). Please try to add the following two lines
> to the top of model_user.c in version 1.0.0 or trunk:
>  #include <sys/types.h>
>  #include <sys/stat.h>
> 
> Let me know how it goes (I certainly hope you check your @mytrashmail.com
> email...)
> 
Now i get this error message:
xfce4_places_plugin-view.o: In function `places_view_init':
/home/andreas/SRC/xfce4-places-plugin-0.3.0/panel-plugin/view.c:98: undefined reference to `g_object_ref_sink'
collect2: ld returned 1 exit status


Comment 3 Diego Ongaro 2007-12-03 21:42:01 CET
Created attachment 1456 
Regarding Comment #2

I accidentally used a function introduced in GObject 2.10. Please try the attached patch (it's only 2 lines). Also, you're probably better off trying 1.0 instead of 0.3.

Sorry you're having so much trouble with this. I guess no one (including me) has actually *tried* running this with older versions of gtk/glib/gobject.
Comment 4 Diego Ongaro 2007-12-09 22:54:52 CET
I created a Debian Sarge chroot with GTK 2.6 and Xfce 4.3.90.2. I fixed all the issues that came up, including the ones from comment #1 and comment #3. I committed these changes in revisions 3683 and 3684. I'll probably release another version with these changes sometime in the next month.

Bug #3707

Reported by:
hellohello
Reported on: 2007-11-30
Last modified on: 2010-11-09

People

Assignee:
Diego Ongaro
CC List:
1 user

Version

Version:
unspecified

Attachments

Regarding Comment #2 (560 bytes, patch)
2007-12-03 21:42 CET , Diego Ongaro
no flags

Additional information