! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Remove borders around buttons on taskbar and panel
Status:
RESOLVED: WONTFIX
Severity:
enhancement
Product:
Xfce4-panel

Comments

Description adisk 2004-10-06 01:23:13 CEST
Look ad this:
+------------------------
|  BORDER    
|.+--------+ +--------+ 
|.|        | |        | 
|.|        | |        | 
| +--------+ +--------+ 
|            
+------------------------

Taskbar placed on the top of screen.
Around buttons on taskbar exist small border (~ 2 pixels)
When move mouse at top of screen, mouse pointer located on border
and when I click on nothing to do. 
It is no good.

Need make taskbar and panel without borders,
like this:

+-+--------+-+--------+--
|.|        | |        | 
|.|        | |        | 
|.|        | |        | 
+-+--------+-+--------+--

Look Mac interface or Icewm taskbar or ROX panels for example.

Thanks.
Comment 1 Jasper Huijsmans editbugs 2004-10-06 05:41:14 CEST
Sure, may be nice. Not as easy as you may think especially for the panel. I'll
take patches for this.
Comment 2 Brian J. Tarricone (not reading bugmail) 2004-10-15 08:09:02 CEST
Created attachment 76 
remove top and bottom border from panel

Not so easy for the panel, eh?	Less than 10 minutes of work ^_~.
Comment 3 Brian J. Tarricone (not reading bugmail) 2004-10-15 08:17:15 CEST
Created attachment 77 
remove top and bottom border of taskbar

Looks like this wasn't so hard for the taskbar either ^_~.  Though I'm not
really sure yet if I like how it looks.  It might be more aesthetically
pleasing to put the border itself back in, and then do some fun catching of
mouse events, followed by resending them a few pixels up (or down) from the
original position.
Comment 4 Jasper Huijsmans editbugs 2004-10-15 08:33:52 CEST
(In reply to comment #3)
> Created an attachment (id=77) [edit]
> remove top and bottom border of taskbar
> 
> Looks like this wasn't so hard for the taskbar either ^_~.  Though I'm not
> really sure yet if I like how it looks.  It might be more aesthetically
> pleasing to put the border itself back in, and then do some fun catching of
> mouse events, followed by resending them a few pixels up (or down) from the
> original position.

I did that once. I even had a patch, but it never got accepted. Can't remember
why (yeah, I know, not a very useful comment).

I'll have a look at that panel patch later, thanks.
Comment 5 Jasper Huijsmans editbugs 2004-10-15 11:24:29 CEST
(In reply to comment #2)
> Created an attachment (id=76) [edit]
> remove top and bottom border from panel
> 
> Not so easy for the panel, eh?	Less than 10 minutes of work ^_~.

ahem, this doesn't actually accomplish much :/

It makes things look bad, because you removed the shadow, and it does not take
away the two pixel border, which is caused by the frame (and the [xy]thickness
of the style).

Earlier in the development I tried to follow Fitts law by pushing the panel
slightly over the screen edge. This works, but is very awkward and was removed
for that reason.

Comment 6 Brian J. Tarricone (not reading bugmail) 2004-10-15 18:28:12 CEST
(In reply to comment #5)
> 
> ahem, this doesn't actually accomplish much :/
> 
> It makes things look bad, because you removed the shadow, and it does not take
> away the two pixel border, which is caused by the frame (and the [xy]thickness
> of the style).

bah, i was afraid of that.  using the Xfce-Basic and Xfce-Smooth themes, it
works, and looks fine (to me).  FYI: i _did_ remove the GtkFrame (and for
simplicity, replaced it with a zero-border GtkBox; actually, i'm suddenly aware
that i didn't call gtk_container_set_border_width() on the GtkBox).  i'm not
sure how the x/y thickness comes into play here, since i'm not fully conversant
in widget style properties, so i'll defer to your judgement.

> Earlier in the development I tried to follow Fitts law by pushing the panel
> slightly over the screen edge. This works, but is very awkward and was removed
> for that reason.

yeah, i remember.  that looked nasty ^_~.

so it looks like the only "real" option is to put the frame back as it was
before, catch mouse events on the frame, calculate the width of the frame, as
well as figure out if we're on the bottom or top of the frame (or left or right
if in vertical mode), and then re-send the event while shifting it off the
border.  sounds like a PITA.  i'll try to give it a look tonight, assuming i
don't collapse and fall asleep after work today.
Comment 7 Jasper Huijsmans editbugs 2004-10-15 18:41:39 CEST
(In reply to comment #6)
> (In reply to comment #5)
> > 
> > ahem, this doesn't actually accomplish much :/
> > 
> > It makes things look bad, because you removed the shadow, and it does not take
> > away the two pixel border, which is caused by the frame (and the [xy]thickness
> > of the style).
> 
> bah, i was afraid of that.  using the Xfce-Basic and Xfce-Smooth themes, it
> works, and looks fine (to me).  FYI: i _did_ remove the GtkFrame (and for
> simplicity, replaced it with a zero-border GtkBox; actually, i'm suddenly aware
> that i didn't call gtk_container_set_border_width() on the GtkBox).  i'm not
> sure how the x/y thickness comes into play here, since i'm not fully conversant
> in widget style properties, so i'll defer to your judgement.
> 

hmm, I must have looked sideways at the patch then, I'll check again ;-)


> > Earlier in the development I tried to follow Fitts law by pushing the panel
> > slightly over the screen edge. This works, but is very awkward and was removed
> > for that reason.
> 
> yeah, i remember.  that looked nasty ^_~.
> 
> so it looks like the only "real" option is to put the frame back as it was
> before, catch mouse events on the frame, calculate the width of the frame, as
> well as figure out if we're on the bottom or top of the frame (or left or right
> if in vertical mode), and then re-send the event while shifting it off the
> border.  sounds like a PITA.  i'll try to give it a look tonight, assuming i
> don't collapse and fall asleep after work today.

Actually, i don't think you should put much effort in it now. When I'll start
using my panel widget stuff (yeah, I know I've been promissing that forever)
this will be much easier.

It would be for 4.4, but it might not be a bad idea to backport it at some point...
Comment 8 Jasper Huijsmans editbugs 2005-03-20 08:00:26 CET
Ok settinging this to WONTFIX for Xfce 4.2, for 4.4 (CVS HEAD) it is already
implemented. Thanks for reporting.

Bug #367

Reported by:
adisk
Reported on: 2004-10-06
Last modified on: 2010-11-20

People

Assignee:
Nick Schermer
CC List:
2 users

Version

Version:
Unspecified

Attachments

remove top and bottom border from panel (987 bytes, patch)
2004-10-15 08:09 CEST , Brian J. Tarricone (not reading bugmail)
no flags
remove top and bottom border of taskbar (1.17 KB, patch)
2004-10-15 08:17 CEST , Brian J. Tarricone (not reading bugmail)
no flags

Additional information