! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
floppy drives should have unique display names if there's more than one insta...
Status:
RESOLVED: WONTFIX
Severity:
enhancement
Product:
Thunar-vfs
Component:
General

Comments

Description Manuel C. 2007-10-12 21:40:27 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.7) Gecko/20070918 BonEcho/2.0.0.7
Build Identifier: 

When 2 or more icons have the *same* name (ex. icons of devices mounted by HAL/volman, like 2 "Drive Floppy" icons if I have 2 floppy drives), xfdesktop can't correctly remember their position/order because it uses the icons names to identify every icon, so if I have 2 ore more icons with the same name, it can't correctly handle the situation.

Reproducible: Always

Steps to Reproduce:
1. Have 2 icons with the same name on the desktop.
2. Re-order them.
3. Restart xfdesktop.

Actual Results:  
The order of one of the two icons isn't remembered.

Expected Results:  
The order of *every* icon should be remembered.
Comment 1 Brian J. Tarricone (not reading bugmail) 2007-11-07 05:57:15 CET
If you have two removable devices with the same name, there is no way to tell them apart unless they are both mounted, and even then, it could be somewhat arbitrary in the case of USB/hotpluggable devices.  Other files with the same 'display name' (like 2 .desktop files with identical Name= lines) will have this problem, but I don't think they're that common.
Comment 2 Manuel C. 2007-11-07 16:19:46 CET
Well... I've this problem with 2 floppy drives because HAL/volman call both "Floppy Drive".

Maybe, if it's possible, you could order them on a "device name" basis if they are devices,

/dev/sda1
/dev/sda2

(or device id)

... or on a "path name" basis if they are files/dirs. 
Comment 3 Brian J. Tarricone (not reading bugmail) 2007-11-07 16:31:36 CET
Thunar-vfs does not provide device name.  I didn't say "there's no way to tell them apart" for nothing.

Benny, any thoughts?  There's no way to tell 2 unmounted removable volumes with the same display name apart, right?  Can't rely on mount points being present when they're unmounted.
Comment 4 Manuel C. 2007-11-07 16:37:03 CET
Maybe, *if it's possible* (as always), Thunar-vfs could be improved.
Comment 5 Manuel C. 2007-11-09 20:58:23 CET
On GNOME, the GNOME's volume manager calls my floppy drives "Floppy Drive" and "Floppy Drive (2)", so this problem doesn't exist.

Maybe we should have a similar behaviour on Xfce: a thunar-volman bug? We could move this bug report to "thunar-volman" product/component.
Comment 6 Manuel C. 2007-11-09 22:21:08 CET
Well... maybe this is more thunar-vfs/gnome-vfs related than volman related...
Comment 7 Brian J. Tarricone (not reading bugmail) 2007-11-09 22:49:01 CET
Well, that's fine for floppy drives, but what happens if you have two USB flash drives with the same volume label (many come from the factory with a preset label)?  gnome-vfs can statically set the /dev/fd0 as 'floppy drive' and /dev/fd1 as 'floppy drive (2)', but you can't predict the plug-in order of USB drives.  The only thing I can think of is to key off the file system's UUID, but a) that'll get changed if the drive gets formatted, b) won't work right for floppies anyway, c) I'm not sure that all file systems have an associated UUID anyway.

Sorry, but I'm beginning to think this is just a WONTFIX, at least for xfdesktop.  The number of people with 2 floppy drives is probably very small, and the only other place this'll show up is for .desktop file shortcuts with the same Name= key, which is somewhat retarded and I don't feel a need to support.

I'm going to move this over to thunar-vfs as you suggest; if Benny wants to special-case floppy drives, that's up to him.
Comment 8 Brian J. Tarricone (not reading bugmail) 2007-11-13 18:32:23 CET
Please don't change fields I've explicitly set.
Comment 9 Manuel C. 2007-11-14 15:55:34 CET
This *is* a *bug* not an enhancement.
Comment 10 Nick Schermer editbugs 2014-12-03 09:19:04 CET
Close bug reports of archived products.

Bug #3603

Reported by:
Manuel C.
Reported on: 2007-10-12
Last modified on: 2014-12-03

People

Assignee:
Jannis Pohlmann
CC List:
2 users

Version

Version:
unspecified

Attachments

Additional information