! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
'New directory' dialog hangs other dialogs
Status:
RESOLVED: FIXED

Comments

Description Tomasz Mon 2007-10-02 15:53:12 CEST
User-Agent:       Mozilla/5.0 (compatible; Konqueror/3.5; Linux) KHTML/3.5.7 (like Gecko)
Build Identifier: 

When I open 'new directory' dialog box, other dialog boxes of thunar are frozen, until I close 'new directory' window.

Reproducible: Always

Steps to Reproduce:
1.run thunar
2.open properties dialog
3.choose create new directory

Actual Results:  
properties dialog doesn't respond to inputs

Expected Results:  
properties dialog should work normally
Comment 1 Benedikt Meurer editbugs 2007-11-28 19:25:23 CET
It's because the "New Folder" dialog is modal.
Comment 2 Benedikt Meurer editbugs 2007-11-28 19:34:01 CET
Hm, no that's not the cause... Olivier any idea? Thunar simply calls set_transient_for() here.
Comment 3 Nick Schermer editbugs 2008-11-25 12:18:57 CET
*** Bug 4355 has been marked as a duplicate of this bug. ***
Comment 4 Nick Schermer editbugs 2008-11-26 21:45:15 CET
This is partly fixed in revision 28918 by implementing GtkWindowGroup for new windows. But not fully working yet. A bit more explanation:

gtk_dialog_run calls gdk_window_set_modal_hint so the window manager will make the dialog modal for the transient window.

It also calls gtk_grab_add for the dialog, which blocks all events delivered to other widgets in the same GtkWindowGroup.

Unfortunatly this doesn't work perfect, because if we have 2 windows and 1 windows runs gtk_dialog_run, the other window is 'usable' but doesn't get focus by the window manager. It also does not respond to key events...

But, when I kill the window manager (xfwm4, trunk) it DOES work as expected. So Olivier, any ideas?
Comment 5 Olivier Fourdan editbugs 2008-11-27 13:49:00 CET
Yes, modality is evil and should be avoided :þ

Seriously though, xfwm4 considers all windows from the same group to be part of the "modality" scope.

Rev. 28925. lessen that constrain and only considers only transients.

Please note that the current code in Thunar is still slightly broken since it allows focalisation of the "Property" dialog but the keyboard remains grabbed in the "New folder", which is quite confusing from a usability point of view.
Comment 6 Nick Schermer editbugs 2008-11-27 17:13:28 CET
I'll fix the property dialog. Appart from that I think we can close this bug.
Comment 7 Nick Schermer editbugs 2008-11-27 19:10:41 CET
The properties dialog is now a standalone window since revision 28930.
Comment 8 Nick Schermer editbugs 2008-12-25 18:52:18 CET
I think all this is fixed.

Bug #3586

Reported by:
Tomasz Mon
Reported on: 2007-10-02
Last modified on: 2009-07-17
Duplicates (1):
  • copy-close Can't close thunar if another instance is waiting for a user interaction

People

Assignee:
Jannis Pohlmann
CC List:
4 users

Version

Version:
unspecified

Attachments

Additional information