! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Show default resolution (instead of "Default") but embolden it
Status:
RESOLVED: FIXED
Severity:
enhancement
Product:
Xfce-mcs
Component:
Plugins

Comments

Description Alexander Toresson 2007-09-27 20:37:07 CEST
Here's a patch that makes the display plugin show the default resolution and frame rate instead of displaying just "Default", but emboldens the text to mark it as the default one. This way, you can actually find out what resolution and frame rate the default resolution has. I've found it odd for quite some time that this info isn't in the gui.
What made me write a patch was that we had a person in #xfce today who said he couldn't make his Xorg produce his preferred resolution, while it actually turned out that he had his preferred resolution set (but the display plugin didn't inform him about this).
Firstly, I tried to instead append " (Default)" to the default mode, but that made for quite a wide list. So after a tip from Darren Salt, I made it bold instead. It works kinda well, only problem would be if people don't understand that the bold one is the default mode.
Also, on a minor note and as another tip from Darren, I exchanged the 'x' separating the width and height in the resolution for the more correct '×'.
Comment 1 Alexander Toresson 2007-09-27 20:38:20 CEST
Created attachment 1371 
The patch
Comment 2 Brian J. Tarricone (not reading bugmail) 2007-09-27 22:59:25 CEST
Can we be sure that all fonts will have the funky non-x x thing?  Safer to just leave it...  Otherwise I'm ok with the patch.

(On a side note, probably best to use the utf8 hex escape sequence to embed it in a string rather than using the raw char.)
Comment 3 Darren Salt 2007-09-29 21:43:03 CEST
It's defined in ISO-8859-1 and the usual set of default (fallback) fonts have it, so no problem that I can see.

As for using \x escapes, I've not seen gcc having problems with including raw UTF-8 in C strings.
Comment 4 Pasi Orovuo 2007-09-30 10:38:17 CEST
Reason for having a do-nothing Default was that for some hardware combinations Randr extension was unable to detect the default resolution (i.e. `xrandr -q` didn't show it), so once the user selected any of the resolutions in the mcs component he was unable to return to the default. I can't find the bug report related so I guess it was discussed in irc at the time. Your patch, if I read it correct, breaks this behavior which should be preserved as there is also another related bug[1].

[1]: http://bugzilla.xfce.org/show_bug.cgi?id=443
Comment 5 Roman Ivanov 2008-12-16 19:26:08 CET
It is really annoying feature to have absolutely uninformative - "Default". User need to use web to get to know their resolution :) - funny but real (http://www.whatismyscreenresolution.com/).

What about putting resolution after like - "Default(1600x1050)"?
If have problem with resolving current resolution of the screen(that is hard to imagine) could you please put Label above - with appropriate content, to define the problem at least.
Comment 6 Yves-Alexis Perez editbugs 2008-12-16 19:40:02 CET
No need for web, just run xrandr in a terminal (the request stays valid, though)
Comment 7 Brian J. Tarricone (not reading bugmail) 2008-12-16 19:46:58 CET
If you can make the change in 5 lines of code or less, then I'd consider accepting it for 4.6.  Otherwise, 4.8, sorry.
Comment 8 Brian J. Tarricone (not reading bugmail) 2008-12-16 19:50:24 CET
(And your patch needs to be against xfce4-settings/dialogs/display/; xfce-mcs-plugins will not get any further code changes.)
Comment 9 Nick Schermer editbugs 2008-12-16 19:56:54 CET
There is no 'default' in 4.6, it selects the real resolution. So this will be fixed in 4.6 and the fix won't land in 4.4.x too. Closing bug.

Bug #3574

Reported by:
Alexander Toresson
Reported on: 2007-09-27
Last modified on: 2009-07-14

People

Assignee:
Xfce Bug Triage
CC List:
3 users

Version

Attachments

The patch (3.25 KB, patch)
2007-09-27 20:38 CEST , Alexander Toresson
no flags

Additional information