! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Set an image to the "Clean recent documents" menu entry
Status:
RESOLVED: FIXED
Priority:
Medium
Severity:
normal
Product:
Ristretto
Component:
Application

Comments

Description Mike Massonnet editbugs 2007-09-03 21:40:02 CEST 
I'm attaching you a patch with 2 more lines for main.c, that sets the GTK_STOCK_CLEAR image beneath the "Clean recent documents" menu entry.

Cheers!
Comment 1 Mike Massonnet editbugs 2007-09-03 21:40:32 CEST 
Created attachment 1342 
clear-recent-menu-entry-with-image.patch
Comment 2 Mike Massonnet editbugs 2007-09-03 21:41:36 CEST 
I'm not sure if you could free() that image, once set however.
Comment 3 Mike Massonnet editbugs 2007-09-03 21:43:44 CEST 
Ah!  Better never do that :o)
Comment 4 Stephan Arts editbugs 2007-09-04 17:46:43 CEST 
(In reply to comment #3)
> Ah!  Better never do that :o)
> 

Nope, widgets (and other gobjects) need to be unreffed when they are no longer used, but containers usually assume reference to the object. (eg, do not increase the reference counter on add, but do decrease it on removal)

BTW, next time you create a patch, could you create it from the top_src directory?

so, ristretto/trunk in this case.

Fixed in rev 3139

Bug #3529

Reported by:
Mike Massonnet
Reported on: 2007-09-03
Last modified on: 2009-07-14

People

Assignee:
Stephan Arts
CC List:
0 users

Version

Version:
unspecified
Target Milestone:
---

Attachments

clear-recent-menu-entry-with-image.patch (958 bytes, text/x-patch)
2007-09-03 21:40 CEST , Mike Massonnet 		no flags

Additional information