! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Thunar crashes when displaying some .jpg files
Status:
RESOLVED: FIXED
Severity:
critical
Product:
Thunar-vfs
Component:
General

Comments

Description Lionel Le Folgoc 2007-08-11 08:29:35 CEST
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.6) Gecko/20070810 Ubuntu/7.10 (gutsy) Firefox/2.0.0.6
Build Identifier: 

Thunar crashes when viewing a folder that contains a certain image (when generating the thumbnails). Changing the file name makes no difference.

Reproducible: Always

Steps to Reproduce:
1. Save one of these pictures in a directory: http://launchpadlibrarian.net/6872702/asd.jpg ; http://launchpadlibrarian.net/8043398/hum.jpg
2. Launch thunar and go to the directory
3. Enjoy ^^"

Actual Results:  
Thunar freezes and finally crashes.

Expected Results:  
Thunar should diplay the thumbnails

(gdb) run
Starting program: /usr/bin/thunar 
Failed to read a valid object file image from memory.
[Thread debugging using libthread_db enabled]
[New Thread -1220589904 (LWP 26643)]
[New Thread -1284945008 (LWP 26646)]
[New Thread -1294992496 (LWP 26647)]
[New Thread -1303385200 (LWP 26648)]
[New Thread -1311777904 (LWP 26649)]
[New Thread -1320170608 (LWP 26650)]
[Thread -1284945008 (LWP 26646) exited]
[Thread -1311777904 (LWP 26649) exited]
[Thread -1303385200 (LWP 26648) exited]
[Thread -1294992496 (LWP 26647) exited]

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread -1320170608 (LWP 26650)]
tvtj_exif_get_ushort (exif=0xb14fc2d8, data=0xb2e0c026) at thunar-vfs-thumb-jpeg.c:334
334     thunar-vfs-thumb-jpeg.c: No such file or directory.
        in thunar-vfs-thumb-jpeg.c
(gdb) thread apply all bt

Thread 6 (Thread -1320170608 (LWP 26650)):
#0  tvtj_exif_get_ushort (exif=0xb14fc2d8, data=0xb2e0c026) at thunar-vfs-thumb-jpeg.c:334
#1  0xb7f65015 in tvtj_exif_parse_ifd (exif=0xb14fc2d8, ifd_ptr=0x0, ifd_len=924) at thunar-vfs-thumb-jpeg.c:371
#2  0xb7f650ee in tvtj_exif_parse_ifd (exif=0xb14fc2d8, ifd_ptr=0xb2e0c028 "\232\202\n", ifd_len=<value optimized out>) at thunar-vfs-thumb-jpeg.c:394
#3  0xb7f650ee in tvtj_exif_parse_ifd (exif=0xb14fc2d8, ifd_ptr=0xb2e0c028 "\232\202\n", ifd_len=<value optimized out>) at thunar-vfs-thumb-jpeg.c:394
#4  0xb7f650ee in tvtj_exif_parse_ifd (exif=0xb14fc2d8, ifd_ptr=0xb2e0c028 "\232\202\n", ifd_len=<value optimized out>) at thunar-vfs-thumb-jpeg.c:394
#5  0xb7f650ee in tvtj_exif_parse_ifd (exif=0xb14fc2d8, ifd_ptr=0xb2e0c028 "\232\202\n", ifd_len=<value optimized out>) at thunar-vfs-thumb-jpeg.c:394
#6  0xb7f650ee in tvtj_exif_parse_ifd (exif=0xb14fc2d8, ifd_ptr=0xb2e0c028 "\232\202\n", ifd_len=<value optimized out>) at thunar-vfs-thumb-jpeg.c:394
#7  0xb7f650ee in tvtj_exif_parse_ifd (exif=0xb14fc2d8, ifd_ptr=0xb2e0c028 "\232\202\n", ifd_len=<value optimized out>) at thunar-vfs-thumb-jpeg.c:394
#8  0xb7f650ee in tvtj_exif_parse_ifd (exif=0xb14fc2d8, ifd_ptr=0xb2e0c028 "\232\202\n", ifd_len=<value optimized out>) at thunar-vfs-thumb-jpeg.c:394
#9  0xb7f650ee in tvtj_exif_parse_ifd (exif=0xb14fc2d8, ifd_ptr=0xb2e0c028 "\232\202\n", ifd_len=<value optimized out>) at thunar-vfs-thumb-jpeg.c:394
#10 0xb7f650ee in tvtj_exif_parse_ifd (exif=0xb14fc2d8, ifd_ptr=0xb2e0c028 "\232\202\n", ifd_len=<value optimized out>) at thunar-vfs-thumb-jpeg.c:394
(this last line is repeated thousands of times)

Bug originally reported at: https://bugs.launchpad.net/ubuntu/+source/thunar/+bug/94000
Comment 1 Benedikt Meurer editbugs 2007-08-11 09:37:36 CEST
Created attachment 1308 
Suggested fix

This patch should fix the problem.
Comment 2 Benedikt Meurer editbugs 2007-08-11 09:42:23 CEST
Committed revision 25967.

2007-08-11	Benedikt Meurer <benny@xfce.org>

	* thunar-vfs/thunar-vfs-thumb-jpeg.c: Prevent infinite recursion
	  on JPEG files with broken exif directories. Bug #3452.

Comment 3 Lionel Le Folgoc 2007-08-11 10:34:31 CEST
Yes, it works fine now, thanks a lot!
Comment 4 Benedikt Meurer editbugs 2007-08-11 11:32:45 CEST
*** Bug 3364 has been marked as a duplicate of this bug. ***

Bug #3452

Reported by:
Lionel Le Folgoc
Reported on: 2007-08-11
Last modified on: 2010-11-07
Duplicates (1):
  • 3364 Thunar 0.8.0 segfaults when trying to create a thumbnail for a certain image

People

Assignee:
Jannis Pohlmann
CC List:
2 users

Version

Version:
unspecified

Attachments

Suggested fix (1.84 KB, patch)
2007-08-11 09:37 CEST , Benedikt Meurer
no flags

Additional information