! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Feature Request: keyboard shortcuts refresh immediately


Description Andrew Conkling 2004-09-27 04:58:02 CEST
When updating keyboard shortcuts under the WM settings, I must restart X
(assumedly to restart the window manager) to get the shortcuts to work.  IMO,
this should happen immediately, especially since Xfce frowns upon having a
"restart WM" option therein.
Comment 1 Jean-François Wauthy editbugs 2004-09-27 16:04:01 CEST
here they are applied immediately (lastest Xfce, freshnew compiled), the
shortcut editor tell the mcs-manager that the keybinding theme changed
Comment 2 Andrew Conkling 2004-10-04 18:51:35 CEST
Yes, same here, but then (at least for me) the shortcuts don't work until I
restart the wm.
Comment 3 Andrew Conkling 2004-10-09 05:59:09 CEST
I'm not so sure that this should be "feature request" and not "bug":
I just tried to add some shortcuts and they didn't work immediately.  
I killed the WM and restarted (something I don't think I should have to do)...
no success.  
I switched to the Default keytheme, confirmed that some of my shortcuts weren't
working, and switched back... no success.
I manually edited the ~/.themes/xfwm4/custom.keys/keythemerc file, added my
shortcuts (which weren't even in there)... still no success.
Now I can't delete the extra shortcuts that I added (how do you do that?)

Seems more like a bug to me...
Comment 4 Olivier Fourdan editbugs 2004-10-09 07:58:50 CEST
You don't need to restart the WM, just switch to another keytheme back and
forth. That's because the shorcut manager change the *content* of the key theme
while MCS notifies the WM when the *"name* of the key theme changes.
Comment 5 Andrew Conkling 2004-10-09 08:32:16 CEST
I should have put those in better order, because the first thing I tried to do
was to change themes back and forth.  That didn't do anything, so THEN I killed
the WM.  Neither way did I have any success.
Comment 6 Olivier Fourdan editbugs 2004-10-09 09:19:00 CEST
Then it's somethign else in your config because changing back and forth *does*
work (not to mention that restarting the WM will work too)
Comment 7 Brian J. Tarricone (not reading bugmail) 2004-10-15 05:49:14 CEST
couldn't the shortcut editor just run 'killall -USR1 xfwm4' after they keytheme
is modified to have xfwm4 reload the it?
Comment 8 Olivier Fourdan editbugs 2004-10-15 06:04:45 CEST
Sorry, I forgot to update that bug. The issue is fixed, I've implemented raw
channels in libxfce4mcs and changed the shortcut editor to use it.

As for the "kill", it wouldn't work because the MCS manager and the client
(xfwm4 in this case) doesn't necessarily run on the same system...

Anyway, I close that bug, it's fixed in CVS for a couple of days.
Comment 9 Andrew Conkling 2004-10-15 06:06:28 CEST
Thanks so much Olivier!

Bug #342

Reported by:
Andrew Conkling
Reported on: 2004-09-27
Last modified on: 2009-07-14


Olivier Fourdan
CC List:
2 users



Additional information