341 – dbh.h not properly handled in xffm (autoconf substitution problem)

dbh.h not properly handled in xffm (autoconf substitution problem)

Status:

RESOLVED: FIXED

Priority:
Medium

Severity:
normal

Product:
Xffm

Component:

General

Comments

Description Ambrose LI Cheuk-Wing 2004-09-27 01:19:26 CEST

Building xffm in HEAD, make errors out with

misc.c:67: dbh.h: No such file or directory
make[2]: *** [libxffm_basic_la-misc.lo] Error 1
make[2]: Leaving directory `/usr/local/archives/checkouts/xfce4/xffm/libs'

Looking at the generated Makefiles, DBH_CFLAGS, DBH_LIBS, and
DBH_REQUIRED_VERSION are defined, but never referenced.

Comment 1 edscott editbugs

2004-09-27 12:12:00 CEST

DBH_CFLAGS has been added to the make file. Compilation should now work OK.

Comment 2 Ambrose LI Cheuk-Wing 2004-09-27 14:28:01 CEST

There are other subdirectories with the same problem (almost all of them). Let
me try to come up with a patch.

Comment 3 Ambrose LI Cheuk-Wing 2004-09-27 16:07:27 CEST

Created attachment 66 
Proposed patch

Sorry, I got this bug mixed up with something else. It's just in libs, not
other directories.

It seems that somehow putting the DBH_CFLAGS in libxffm_basic_la_CFLAGS is not
enough. Moving it elsewhere (see attached patch) seems to work.

Comment 4 edscott editbugs

2004-09-27 16:15:29 CEST

I've committed the patch. The location where the DBH_CFLAGS is now at is
equivalent to using it for all libraries (better safe than sorry ;)

Comment 5 Jasper Huijsmans editbugs

2004-10-27 13:12:34 CEST

Apparently this has been fixed.

Bug #341

Reported by:
Ambrose LI Cheuk-Wing

Reported on: 2004-09-27
Last modified on: 2009-07-14

People

Assignee:
edscott

CC List:
0 users

Version

Version:
unspecified

Target Milestone:
---

Attachments

Proposed patch (1.40 KB, patch)
2004-09-27 16:07 CEST , Ambrose LI Cheuk-Wing

no flags

Additional information