! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
xfce_gdk_spawn_make_environment_for_screen should not be #if 0'd
Status:
CLOSED: FIXED
Product:
Libxfcegui4
Component:
General

Comments

Description Ambrose LI Cheuk-Wing 2004-09-26 15:34:34 CEST
When xfce_gdk_spawn_make_environment_for_screen (in
libxfcegui4/libxfcegui4/xfce-gdk-extensions.c) is #if 0'd (currently the case in
HEAD), xfcalendar fails to *link* for some obscure reason:

/software/x11_xfce/lib/libxfcegui4.so: undefined reference to
`xfce_gdk_spawn_make_environment_for_screen'
collect2: ld returned 1 exit status
make[2]: *** [xfcalendar] Error 1
make[2]: Leaving directory `/usr/local/archives/checkouts/xfce4/xfcalendar/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/usr/local/archives/checkouts/xfce4/xfcalendar'
make: *** [all] Error 2

Changing the #if 0 to a #if 1 makes this strange link error disappear.
Comment 1 Jasper Huijsmans editbugs 2004-09-26 19:13:52 CEST
That's weird. If anything, i'd expect you to see this with other programs as
well. Is it really only with xfcalendar?
Comment 2 Brian J. Tarricone (not reading bugmail) 2004-09-26 23:04:19 CEST
odd.  i #if 0'd that out, because it was unused... ok, the function is marked as
static and doesn't have a prototype in the header file.  oh, ok.  it's used only
for gtk 2.2 and below, and should be protected as such.  fix committed; please
test and mark this bug VERIFIED if it works ok (after the usual hour for anoncvs
to sync up).
Comment 3 Ambrose LI Cheuk-Wing 2004-09-27 00:58:36 CEST
Fix verified working.

Bug #338

Reported by:
Ambrose LI Cheuk-Wing
Reported on: 2004-09-26
Last modified on: 2009-07-15

People

Assignee:
Xfce Bug Triage
CC List:
0 users

Version

Version:
unspecified

Attachments

Additional information