! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
Reordering of files
Status:
RESOLVED: FIXED
Severity:
enhancement

Comments

Description Mathias Brodala 2007-06-09 16:29:57 CEST
User-Agent:       Opera/9.21 (X11; Linux i686; U; de)
Build Identifier: 

It should be possible to reorder files manually in renamer’s file list.

Reproducible: Always

Steps to Reproduce:
1. Add files to renamer’s list
2. Try to drag and drop them around within that list

Actual Results:  
Nothin happens.

Expected Results:  
The renamer should move files where they ought to be.
Comment 1 Nick Schermer editbugs 2008-12-02 18:12:35 CET
Created attachment 2012 
Patch to implement reorder

Here is a patch to implement reorder in the renamer dialog.

thunar-renamer-model:
- Adds a new function to move a list of GtkTreePaths to a new position in the list.
- Renames thunar_renamer_model_append to thunar_renamer_model_insert() so we can send an insert position.
- Macro for thunar_renamer_model_append to use thunar_renamer_model_insert(.., -1).

thunar-renamer-dialog:
- Use the exo-tree-view instead of gtk-tree-view, so we can implement rubberbanding (for dnd and remove).
- Dnd changes: insert in position in the list, reorder rows in the list.
Comment 2 Nick Schermer editbugs 2008-12-02 18:15:28 CET
While the focus for the 1.2 flag is bugfixes, I think this is a nice addition to the renamer, and it actually makes the numbering renamer useful. So maybe if we do some testing and reviewing, we can get this in thunar before the Xfce 4.6b3 release (??).
Comment 3 Jannis Pohlmann editbugs 2008-12-03 12:20:19 CET
(In reply to comment #2)
> While the focus for the 1.2 flag is bugfixes, I think this is a nice addition
> to the renamer, and it actually makes the numbering renamer useful. So maybe if
> we do some testing and reviewing, we can get this in thunar before the Xfce
> 4.6b3 release (??).

Works fine here. I'm ok with a few new features as long as they are not major ones. Feel free to commit.
Comment 4 Nick Schermer editbugs 2008-12-03 18:11:29 CET
Committed in revision 28975.

Bug #3325

Reported by:
Mathias Brodala
Reported on: 2007-06-09
Last modified on: 2009-07-17

People

Assignee:
Jannis Pohlmann
CC List:
2 users

Version

Attachments

Patch to implement reorder (20.15 KB, patch)
2008-12-02 18:12 CET , Nick Schermer
no flags

Additional information