! Please note that this is a snapshot of our old Bugzilla server, which is read only since May 29, 2020. Please go to gitlab.xfce.org for our new server !
launcher_update_panel_entry on 4.4 br corrupts stack with bad g_snprintf length
Status:
CLOSED: FIXED
Product:
Xfce4-panel
Component:
Launcher

Comments

Description Gregory Andersen 2007-06-08 15:56:15 CEST
launcher.c:launcher_update_panel_entry on the 4.4 branch defines char tip[512], but the subsequent g_snprintf and g_strlcpy use 521 as the length.  This ends up corrupting the stack (at least on HPUX) which causes the panel to crash.  Updating the values to 512 fixes the issue.
Comment 1 Nick Schermer editbugs 2007-06-08 16:07:03 CEST
Better use sizeof(tip) in the g_snprintf and g_strlcpy functions.
Comment 2 Jasper Huijsmans editbugs 2007-06-10 09:51:33 CEST
Seems I was temporarily dyslectic there...

I committed a fix with SVN revision 25792, so the problem should be solved in the next release of Xfce. Thanks a lot for the report.

Bug #3324

Reported by:
Gregory Andersen
Reported on: 2007-06-08
Last modified on: 2010-11-20

People

Assignee:
Nick Schermer
CC List:
0 users

Version

Version:
Unspecified

Attachments

Additional information